-
Notifications
You must be signed in to change notification settings - Fork 12
Add OutputBuilder creation from Box object
#184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: a33850a The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@fleet-sdk/blockchain-providers
@fleet-sdk/common
@fleet-sdk/compiler
@fleet-sdk/core
@fleet-sdk/crypto
@fleet-sdk/mock-chain
@fleet-sdk/serializer
@fleet-sdk/wallet
@fleet-sdk/ageusd-plugin
@fleet-sdk/babel-fees-plugin
commit: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #184 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 125 125
Lines 13977 13982 +5
Branches 1698 1699 +1
=========================================
+ Hits 13977 13982 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new static method on OutputBuilder to create an instance from various Box types, addressing issue #183.
- Adds a new static from() method that initializes an OutputBuilder with values extracted from a Box object.
- Extends the test suite to verify the behavior of the new from() method.
- Updates the changeset to document the new feature.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/core/src/builder/outputBuilder.ts | Introduces static from() to create an OutputBuilder from a Box object. |
| packages/core/src/builder/outputBuilder.spec.ts | Adds tests to verify the creation of an OutputBuilder from a Box. |
| .changeset/three-needles-smell.md | Documents the new OutputBuilder creation from a Box. |
Comments suppressed due to low confidence (1)
packages/core/src/builder/outputBuilder.spec.ts:81
- [nitpick] Consider renaming the variable 'builded' to 'builtOutput' for improved readability and grammatical accuracy.
const builded = builder.setCreationHeight(box.creationHeight).build();
Fixes #183