Skip to content

Conversation

@arobsn
Copy link
Member

@arobsn arobsn commented May 20, 2025

Fixes #183

@changeset-bot
Copy link

changeset-bot bot commented May 20, 2025

🦋 Changeset detected

Latest commit: a33850a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@fleet-sdk/core Patch
@fleet-sdk/blockchain-providers Patch
@fleet-sdk/compiler Patch
@fleet-sdk/mock-chain Patch
@fleet-sdk/wallet Patch
@fleet-sdk/ageusd-plugin Patch
@fleet-sdk/babel-fees-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented May 20, 2025

@fleet-sdk/blockchain-providers

npm i https://pkg.pr.new/@fleet-sdk/blockchain-providers@184

@fleet-sdk/common

npm i https://pkg.pr.new/@fleet-sdk/common@184

@fleet-sdk/compiler

npm i https://pkg.pr.new/@fleet-sdk/compiler@184

@fleet-sdk/core

npm i https://pkg.pr.new/@fleet-sdk/core@184

@fleet-sdk/crypto

npm i https://pkg.pr.new/@fleet-sdk/crypto@184

@fleet-sdk/mock-chain

npm i https://pkg.pr.new/@fleet-sdk/mock-chain@184

@fleet-sdk/serializer

npm i https://pkg.pr.new/@fleet-sdk/serializer@184

@fleet-sdk/wallet

npm i https://pkg.pr.new/@fleet-sdk/wallet@184

@fleet-sdk/ageusd-plugin

npm i https://pkg.pr.new/@fleet-sdk/ageusd-plugin@184

@fleet-sdk/babel-fees-plugin

npm i https://pkg.pr.new/@fleet-sdk/babel-fees-plugin@184

commit: a33850a

@codecov
Copy link

codecov bot commented May 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (824688d) to head (a33850a).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #184   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          125       125           
  Lines        13977     13982    +5     
  Branches      1698      1699    +1     
=========================================
+ Hits         13977     13982    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arobsn arobsn requested a review from Copilot May 20, 2025 23:37
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new static method on OutputBuilder to create an instance from various Box types, addressing issue #183.

  • Adds a new static from() method that initializes an OutputBuilder with values extracted from a Box object.
  • Extends the test suite to verify the behavior of the new from() method.
  • Updates the changeset to document the new feature.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
packages/core/src/builder/outputBuilder.ts Introduces static from() to create an OutputBuilder from a Box object.
packages/core/src/builder/outputBuilder.spec.ts Adds tests to verify the creation of an OutputBuilder from a Box.
.changeset/three-needles-smell.md Documents the new OutputBuilder creation from a Box.
Comments suppressed due to low confidence (1)

packages/core/src/builder/outputBuilder.spec.ts:81

  • [nitpick] Consider renaming the variable 'builded' to 'builtOutput' for improved readability and grammatical accuracy.
const builded = builder.setCreationHeight(box.creationHeight).build();

@arobsn arobsn merged commit 8fd796a into master May 20, 2025
16 checks passed
@arobsn arobsn deleted the arobsn/i183 branch May 20, 2025 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Construct OutputBuilder from box

2 participants