-
Notifications
You must be signed in to change notification settings - Fork 50
Fleet gitops directory: Add structure #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fleet gitops directory: Add structure #69
Conversation
getvictor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes make sense to me.
FYI: @noahtalerman @eugkuo regarding this customer-facing change.
|
Thanks @getvictor ! I added 2 installer yml examples (one for windows one for macos) since your approval if you have a moment |
getvictor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not simply point people to these examples in the fleet repo? If we're putting configs into this repo, the customer expectation would be that they actually work, which means we are continually testing them for regressions. That's not the case -- we only have smoke tests of the main configs (free/premium) for this repo.
Agreed. @RachelElysia I think we want to keep this GitOps repo as light as possible so that when a customer tries it, it always works. Maybe we remove the software examples to get this PR merged in? We can remove other stale examples in a follow up pass. |
|
@RachelElysia also heads up that @harrisonravazzolo has been using this repo during GitOps training sessions. I added Harry as a reviewer to this PR. I think we want his eyes before we merge in the changes. For this reason, I also updated CODEOWNERS such that Harry owns the best practice file structure: #70 |
|
Thanks for the review @getvictor and context @noahtalerman ! @harrisonravazzolo As DRI, please confirm and update this task so I'm not aiming in the dark of what is being asked fleetdm/fleet#29293 -- Grazie! cc: @mostlikelee |
| @@ -1 +0,0 @@ | |||
| # This will be a script that uninstalls Zoom from macOS hosts. No newline at end of file | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We currently have this very generic example of uninstall zoom script in here. Is that preferred than an actual script?
That's an option for keeping the santa.yml or slack.yml as a reference. lmk!
harrisonravazzolo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All make sense to me @RachelElysia - thanks for checking and apologies for the delay, was traveling yesterday!
|
@harrisonravazzolo when you merge this in, can you leave a comment on fleetdm/fleet#29293 saying that you QAed for transparency <3 |
|
@RachelElysia - sure thing. going to merge this afternoon |
Issue
Part of fleetdm/fleet#29293
Description
lib/uninstall-zoom.script.shas it was 1) empty and 2) is confusing if it's part of a general script or a software's uninstall script/lib/agent-options.ymlinto/lib/agent-options/agent-options.ymlas it's fails gitops CI test moving it