small FE fixes to align with test plan and Figma #37985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 33509-feature-branch #37985 +/- ##
=======================================================
Coverage ? 65.81%
=======================================================
Files ? 2368
Lines ? 187621
Branches ? 7945
=======================================================
Hits ? 123490
Misses ? 52848
Partials ? 11283
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
frontend/pages/hosts/components/TransferHostModal/TransferHostModal.tests.tsx
Outdated
Show resolved
Hide resolved
frontend/pages/hosts/components/TransferHostModal/TransferHostModal.tsx
Outdated
Show resolved
Hide resolved
…Modal.tsx Co-authored-by: jacobshandling <[email protected]>
| onClickLock={() => { | ||
| setShowLockHostModal(true); | ||
| setShowLocationModal(undefined); | ||
| setShowLocationModal(false); |
Member
There was a problem hiding this comment.
wert, why didn't TS catch this?
Member
There was a problem hiding this comment.
So I don't think we actually want to change this, see #37660 (comment)
2 tasks
frontend/pages/hosts/details/HostDetailsPage/modals/LockModal/LockModal.tsx
Outdated
Show resolved
Hide resolved
…LockModal.tsx Co-authored-by: jacobshandling <[email protected]>
ghernandez345
requested changes
Jan 8, 2026
frontend/pages/hosts/components/TransferHostModal/TransferHostModal.tests.tsx
Outdated
Show resolved
Hide resolved
jahzielv
changed the title
iansltx
reviewed
Jan 8, 2026
frontend/pages/hosts/details/HostDetailsPage/modals/LockModal/LockModal.tsx
Show resolved
Hide resolved
iansltx
reviewed
Jan 8, 2026
frontend/pages/hosts/details/HostDetailsPage/HostDetailsPage.tsx
Outdated
Show resolved
Hide resolved
iansltx
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No ticket, just some unreleased issues noticed while doing the test plan
Checklist for submitter
If some of the following don't apply, delete the relevant line.
Testing
For unreleased bug fixes in a release candidate, one of: