Skip to content

[Hotfix Main]: [FXC-2300] Improved error message when using legacy output field names #1367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benflexcompute merged 3 commits into from
Aug 19, 2025
Merged

[Hotfix Main]: [FXC-2300] Improved error message when using legacy output field names #1367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f72f0d0
[FXC-2300] Improved error message when using legacy output field name…
benflexcompute Aug 16, 2025
5cf041a
Merge branch 'main' into hotfix-main-pr1366
benflexcompute Aug 18, 2025
7ab714f
Merge branch 'main' into hotfix-main-pr1366
benflexcompute Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion flow360/component/simulation/user_code/core/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,7 +529,9 @@ def check_value_is_not_legacy_variable(cls, v):

all_field_names = set(AllFieldNames.__args__)
if v in all_field_names:
raise ValueError(f"'{v}' is a reserved (legacy) output field name.")
raise ValueError(
f"'{v}' is a reserved (legacy) output field name. It cannot be used in expressions."
)
return v

@pd.field_validator("name", mode="after")
Expand Down
15 changes: 12 additions & 3 deletions tests/simulation/test_expressions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -874,9 +874,18 @@ def test_unique_dimensions():
("template", "'template' is a reserved keyword."),
("temperature", "'temperature' is a reserved solver side variable name."),
("area", "'area' is a reserved solver side variable name."),
("velocity", "'velocity' is a reserved (legacy) output field name."),
("mut", "'mut' is a reserved (legacy) output field name."),
("pressure", "'pressure' is a reserved (legacy) output field name."),
(
"velocity",
"'velocity' is a reserved (legacy) output field name. It cannot be used in expressions.",
),
(
"mut",
"'mut' is a reserved (legacy) output field name. It cannot be used in expressions.",
),
(
"pressure",
"'pressure' is a reserved (legacy) output field name. It cannot be used in expressions.",
),
],
)
def test_invalid_names_raise(bad_name, expected_msg):
Expand Down
Loading