[Hotfix Main]: fix(): Added a check to skip validation for legacy cloud assets without bounding box information in the simulation parameters validation function. #1710
+360
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut bounding box information in the simulation parameters validation function. (#1709)
…assets
When legacy cloud assets lack private_attributes (bounding box information),
downgrade missing boundary condition errors to warnings instead of hard errors.
This prevents validation failures for old simulation.json files that don't
have bounding box data.
Changes:
- Modified _collect_asset_boundary_entities to detect legacy assets (all
boundaries missing private_attributes) and return the flag
- Updated _validate_boundary_completeness to accept has_missing_private_attributes
parameter and downgrade errors to warnings when detected
- Improved warning message: "If these boundaries are valid, please add them to
a boundary condition model in the `models` section."
- Added test case to verify legacy asset warning behavior
- Fixed test_beta_mesher_only_features to include private_attributes for surfaces
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 22397917fe
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hotfix of PR #1709 (#1709) to the
mainbranch.Hey @benflexcompute, please review this hotfix PR created from your original PR.
Note
Hotfix updates boundary-condition validation to be tolerant of legacy assets that lack
private_attributes(e.g., bounding boxes)._collect_asset_boundary_entitiesand returns(entities, has_missing_private_attributes); skips deletion filtering when legacy is detectedhas_missing_private_attributesto_validate_boundary_completenessto downgrade missing-BC errors to warnings (with clarified message)_check_complete_boundary_condition_and_unknown_surfaceprivate_attributeswhere needed and addstest_legacy_asset_missing_private_attributesto verify warning behaviortests/.../surface_mesh/simulation.json) to includeprivate_attributesfor boundariesWritten by Cursor Bugbot for commit c778d48. This will update automatically on new commits. Configure here.