Skip to content

[Hotfix 25.7]: fix(): Added a check to skip validation for legacy cloud assets without bounding box information in the simulation parameters validation function. #1711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benflexcompute merged 2 commits into from
Jan 9, 2026
Merged

[Hotfix 25.7]: fix(): Added a check to skip validation for legacy cloud assets without bounding box information in the simulation parameters validation function. #1711

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8426f9
fix(): Added a check to skip validation for legacy cloud assets witho…
benflexcompute Jan 9, 2026
87c667e
Manual fix
benflexcompute Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions flow360/component/simulation/validation/validation_simulation_params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,6 +336,11 @@ def _check_complete_boundary_condition_and_unknown_surface(

# If transformed then `_will_be_deleted_by_mesher()` will no longer be accurate
# since we do not know the final bounding box for each surface and global model.
if farfield_method:
for item in asset_boundary_entities:
if item.private_attributes is None:
# Legacy cloud asset that does not have bounding box information. Just skip the check.
return params
# pylint:disable=protected-access
asset_boundary_entities = [
item
Expand Down
238 changes: 224 additions & 14 deletions tests/simulation/params/data/surface_mesh/simulation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,22 @@
"private_attribute_is_interface": null,
"private_attribute_tag_key": null,
"private_attribute_sub_components": [],
"private_attribute_color": null
"private_attribute_color": null,
"private_attributes": {
"type_name": "SurfacePrivateAttributes",
"bounding_box": [
[
0,
0,
0
],
[
1,
1,
1
]
]
}
},
{
"private_attribute_registry_bucket_name": "SurfaceEntityType",
Expand All @@ -355,7 +370,22 @@
"private_attribute_is_interface": null,
"private_attribute_tag_key": null,
"private_attribute_sub_components": [],
"private_attribute_color": null
"private_attribute_color": null,
"private_attributes": {
"type_name": "SurfacePrivateAttributes",
"bounding_box": [
[
0,
0,
0
],
[
1,
1,
1
]
]
}
},
{
"private_attribute_registry_bucket_name": "SurfaceEntityType",
Expand All @@ -366,7 +396,22 @@
"private_attribute_is_interface": null,
"private_attribute_tag_key": null,
"private_attribute_sub_components": [],
"private_attribute_color": null
"private_attribute_color": null,
"private_attributes": {
"type_name": "SurfacePrivateAttributes",
"bounding_box": [
[
0,
0,
0
],
[
1,
1,
1
]
]
}
},
{
"private_attribute_registry_bucket_name": "SurfaceEntityType",
Expand All @@ -377,7 +422,22 @@
"private_attribute_is_interface": null,
"private_attribute_tag_key": null,
"private_attribute_sub_components": [],
"private_attribute_color": null
"private_attribute_color": null,
"private_attributes": {
"type_name": "SurfacePrivateAttributes",
"bounding_box": [
[
0,
0,
0
],
[
1,
1,
1
]
]
}
},
{
"private_attribute_registry_bucket_name": "SurfaceEntityType",
Expand All @@ -388,7 +448,22 @@
"private_attribute_is_interface": null,
"private_attribute_tag_key": null,
"private_attribute_sub_components": [],
"private_attribute_color": null
"private_attribute_color": null,
"private_attributes": {
"type_name": "SurfacePrivateAttributes",
"bounding_box": [
[
0,
0,
0
],
[
1,
1,
1
]
]
}
},
{
"private_attribute_registry_bucket_name": "SurfaceEntityType",
Expand All @@ -399,7 +474,22 @@
"private_attribute_is_interface": null,
"private_attribute_tag_key": null,
"private_attribute_sub_components": [],
"private_attribute_color": null
"private_attribute_color": null,
"private_attributes": {
"type_name": "SurfacePrivateAttributes",
"bounding_box": [
[
0,
0,
0
],
[
1,
1,
1
]
]
}
},
{
"private_attribute_registry_bucket_name": "SurfaceEntityType",
Expand All @@ -410,7 +500,22 @@
"private_attribute_is_interface": null,
"private_attribute_tag_key": null,
"private_attribute_sub_components": [],
"private_attribute_color": null
"private_attribute_color": null,
"private_attributes": {
"type_name": "SurfacePrivateAttributes",
"bounding_box": [
[
0,
0,
0
],
[
1,
1,
1
]
]
}
},
{
"private_attribute_registry_bucket_name": "SurfaceEntityType",
Expand All @@ -421,7 +526,22 @@
"private_attribute_is_interface": null,
"private_attribute_tag_key": null,
"private_attribute_sub_components": [],
"private_attribute_color": null
"private_attribute_color": null,
"private_attributes": {
"type_name": "SurfacePrivateAttributes",
"bounding_box": [
[
0,
0,
0
],
[
1,
1,
1
]
]
}
},
{
"private_attribute_registry_bucket_name": "SurfaceEntityType",
Expand All @@ -432,7 +552,22 @@
"private_attribute_is_interface": null,
"private_attribute_tag_key": null,
"private_attribute_sub_components": [],
"private_attribute_color": null
"private_attribute_color": null,
"private_attributes": {
"type_name": "SurfacePrivateAttributes",
"bounding_box": [
[
0,
0,
0
],
[
1,
1,
1
]
]
}
},
{
"private_attribute_registry_bucket_name": "SurfaceEntityType",
Expand All @@ -443,7 +578,22 @@
"private_attribute_is_interface": null,
"private_attribute_tag_key": null,
"private_attribute_sub_components": [],
"private_attribute_color": null
"private_attribute_color": null,
"private_attributes": {
"type_name": "SurfacePrivateAttributes",
"bounding_box": [
[
0,
0,
0
],
[
1,
1,
1
]
]
}
},
{
"private_attribute_registry_bucket_name": "SurfaceEntityType",
Expand All @@ -454,7 +604,22 @@
"private_attribute_is_interface": null,
"private_attribute_tag_key": null,
"private_attribute_sub_components": [],
"private_attribute_color": null
"private_attribute_color": null,
"private_attributes": {
"type_name": "SurfacePrivateAttributes",
"bounding_box": [
[
0,
0,
0
],
[
1,
1,
1
]
]
}
},
{
"private_attribute_registry_bucket_name": "SurfaceEntityType",
Expand All @@ -465,7 +630,22 @@
"private_attribute_is_interface": null,
"private_attribute_tag_key": null,
"private_attribute_sub_components": [],
"private_attribute_color": null
"private_attribute_color": null,
"private_attributes": {
"type_name": "SurfacePrivateAttributes",
"bounding_box": [
[
0,
0,
0
],
[
1,
1,
1
]
]
}
},
{
"private_attribute_registry_bucket_name": "SurfaceEntityType",
Expand All @@ -476,7 +656,22 @@
"private_attribute_is_interface": null,
"private_attribute_tag_key": null,
"private_attribute_sub_components": [],
"private_attribute_color": null
"private_attribute_color": null,
"private_attributes": {
"type_name": "SurfacePrivateAttributes",
"bounding_box": [
[
0,
0,
0
],
[
1,
1,
1
]
]
}
},
{
"private_attribute_registry_bucket_name": "SurfaceEntityType",
Expand All @@ -487,7 +682,22 @@
"private_attribute_is_interface": null,
"private_attribute_tag_key": null,
"private_attribute_sub_components": [],
"private_attribute_color": null
"private_attribute_color": null,
"private_attributes": {
"type_name": "SurfacePrivateAttributes",
"bounding_box": [
[
0,
0,
0
],
[
1,
1,
1
]
]
}
}
],
"global_bounding_box": [
Expand Down
Loading
Loading