Revert "refactor(): Moved implementation of the report functionality out of Flow360 package" #1721
Conversation
…out of F…" This reverts commit d103a56.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d4b9077d33
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| report_template.create_in_cloud( | ||
| name=f"{name}-summary", | ||
| cases=[case], | ||
| solver_version=solver_version if solver_version else self.solver_version, | ||
| ) |
There was a problem hiding this comment.
The new unconditional create_in_cloud call means run_case now depends on the report API succeeding; if the report service is unavailable or the user lacks report permissions, create_in_cloud will raise and run_case fails even though the case has already been created. This can make callers think the case submission failed and trigger retries/duplicates. Consider making report creation optional or catching/reporting Flow360WebError so run_case still returns the created case when report creation fails.
Useful? React with 👍 / 👎.
Reverts #1614
The migration was not completed yet on PROD env.
Note
Restores the internal reporting system and integrates cloud report submission.
flow360.plugins.report(templates, 2D/3D charts, cameras, LaTeX doc, utils) with assets and READMENewReportRequest,Report,ReportDraft), plus image rendering via shutterflow360.report) and addsget_default_report_summary_template()/get_default_report_config()Project.run_casenow triggers creation of a default summary report in cloudautomotive_report.py,geometry_to_report.py, sweep templates, BET/CHT scripts, notebook)Written by Cursor Bugbot for commit d4b9077. This will update automatically on new commits. Configure here.