[FXC-5593] feat(): VGPU access.#1797
Open
benflexcompute wants to merge 6 commits intorelease-candidate/25.8from
Open
[FXC-5593] feat(): VGPU access.#1797benflexcompute wants to merge 6 commits intorelease-candidate/25.8from
benflexcompute wants to merge 6 commits intorelease-candidate/25.8from
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 35701bf524
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Touches case submission request shaping and adds an account-capability check that can block runs when vGPU is requested; incorrect mapping/field omission could cause API submission failures or unexpected billing/queue behavior.
Overview
Adds support for Virtual GPU (vGPU) billing and queue priority when running cases/drafts.
DraftRunRequestnow accepts optionaljob_type(TIME_SHARED_VGPU/FLEX_CREDIT) andpriority(1–10), andDraft.run_up_to_target_asset()forwards these fields while omitting them from the request body when unset.Project.run_case()introduces user-facingbilling_method(VirtualGPU/FlexCredit) pluspriority, maps billing to APIjob_type, verifies vGPU access viaGET flow360/account, and ignores/filters priority when not applicable (non-vGPU ordraft_only). Includes new unit tests validatingpriorityrange and serialization, plus minor typing annotations in helper functions.Written by Cursor Bugbot for commit 37253f8. This will update automatically on new commits. Configure here.