Upgrade ruff 0.5.5 -> 0.11.11

Run `ruff check . --fix`

Run `ruff format .`

Move test-specifc `ruff.toml` to `per-file-ignores`

Sort test imports

Import `Literal` from `typing`

Force `from __future__ import annotations` import

Rewrite `dict()` as literal (2x faster)

Disallow function calls in default arguments

Be intentional about exception context

Upgrade all (compatible) generics to built-in types

Sort `__all__` blocks

Enable `RUF` ruleset

Prefer tuple unpacking over concatenation

Forbid implicit optional

No explicit string concatenation

Remove unnecessary `pass` statements

Remove unnecessary parantheses on raised exceptions

Disallow relative imports from parent modules

Remove unused import aliases

Add lint rule comments

Revert "Disallow function calls in default arguments"

This reverts commit 12a0a6a.

Fix some stragglers

Updated ruff version in workflow

Lint `data/` dirs

rebase fixes

sentinel pattern for function calls in default arguments

rebase fixes

Author: yaugenst-flex

.github/workflows/run_tests.yml

@@ -122,7 +122,7 @@ jobs:
           fetch-depth: 1
       - uses: astral-sh/ruff-action@v3
         with:
-          version: 0.5.5
+          version: 0.11.11
       - name: Run ruff format
         run: ruff format --check --diff
       - name: Run ruff check

.pre-commit-config.yaml

@@ -1,6 +1,6 @@
 repos:
   - repo: https://github.com/astral-sh/ruff-pre-commit
-    rev: "v0.5.5"
+    rev: "v0.11.11"
     hooks:
      - id: ruff
        args: [ --fix ]

docs/_ext/custom-meta.py

@@ -1,3 +1,5 @@
+from __future__ import annotations
+
 import os
 
 

docs/_ext/custom-robots.py

@@ -1,3 +1,5 @@
+from __future__ import annotations
+
 import os
 
 

docs/_ext/custom-sitemap.py

@@ -1,3 +1,5 @@
+from __future__ import annotations
+
 import re
 import xml.etree.ElementTree as ET
 

docs/conf.py

@@ -17,6 +17,8 @@
 # relative to the documentation root, use os.path.abspath to make it
 # absolute, like shown here.
 #
+from __future__ import annotations
+
 import datetime
 import logging
 import os

docs/generate_doc.py

@@ -1,4 +1,5 @@
 # Generate documentation for Material Library (Python)
+from __future__ import annotations
 
 import numpy as np
 
@@ -24,8 +25,7 @@ def generate_material_library_doc():
     def num2str(num):
         if np.isinf(num):
             return " "
-        else:
-            return str(round(num, 2))
+        return str(round(num, 2))
 
     with open(fname, "w") as f:
         # Write file header
@@ -238,8 +238,7 @@ def generate_rf_material_library_doc():
     def num2str(num):
         if np.isinf(num):
             return " "
-        else:
-            return str(round(num, 2))
+        return str(round(num, 2))
 
     with open(fname, "w") as f:
         # Write file header

poetry.lock

@@ -52,7 +52,7 @@ joblib = "*"
 ### Optional dependencies ###
 # development core
 bump-my-version = { version = "*", optional = true }
-ruff = { version = "0.5.5", optional = true }
+ruff = { version = "0.11.11", optional = true }
 coverage = { version = "*", optional = true }
 dill = { version = "*", optional = true }
 ipython = { version = "*", optional = true }
@@ -245,31 +245,48 @@ line-length = 100
 extend-exclude = ["docs/faq/", "docs/notebooks/"]
 
 [tool.ruff.lint]
-typing-modules = [
-  "tidy3d.components.types",
-] # without this Literal["something fails"]
-select = [
-  "I",      # isort
+extend-select = [
   "E",      # pycodestyle errors
-  "W",      # pycodestyle warnings
   "F",      # pyflakes
-  "C",      # flake8-comprehensions
-  "B",      # flake8-bugbear
-  "UP",
-  "NPY201", # numpy 2.* compatibility check
+  "B",      # bugbear
+  "I",      # isort
+  "UP",     # pyupgrade
+  "W",      # pycodestyle
+  "C4",     # flake8-comprehensions
+  "NPY",    # numpy-specific rules
+  "RUF",    # ruff builtins
+  "ISC",    # implicit string concatenation
+  "PIE",    # flake8-pie
+  "RSE",    # unnecessary parantheses on raised exceptions
+  "TID",    # no relative imports from parent modules
+  "PLE",    # pylint errors
+  "PLC",    # pylint conventions
+]
+extend-ignore = [
+  "RUF001", # ambiguous unicode characters
+  "RUF002", # ambiguous unicode characters
+  "RUF003", # ambiguous unicode characters
+  "RUF012", # type hints for mutable defaults
+  "RUF015", # next(iter(...)) instead of list(...)[0]
+  "E501",   # line too long
+  "B905",   # `zip()` without an explicit `strict=` parameter
+  "UP007",  # TODO: Remove once Python >= 3.10
+  "NPY002", # TODO: Revisit RNG handling
 ]
-ignore = [
-  "E501",
-  "B008",  # do not perform function calls in argument defaults
-  "C901",  # too complex
-  "UP007", # use x | y instead of union[x,y] (does not work)
-  "B905",  # `zip()` without an explicit `strict=` parameter
-  "C408",  # C408 Unnecessary `dict` call (rewrite as a literal)
-  "B904",
-  "B028",  # stacklevel
-  "UP006", # typy annotation with Tuple[float] messes up pydantic
-  "UP038", # TODO decide what to do here
-  "UP035", # TODO decide what to do here
+
+[tool.ruff.lint.isort]
+required-imports = ["from __future__ import annotations"]
+
+[tool.ruff.lint.per-file-ignores]
+"tests/**/*" = [
+    "B015",   # useless comparison
+    "B018",   # useless expression
+    "E402",   # module-level import not at top of file
+    "E731",   # lambda assignment
+    "F841",   # unused local variable
+    "S101",   # asserts allowed in tests
+    "NPY201", # numpy 2.* compatibility check
+    "TID252", # allow relative imports in tests
 ]
 
 [tool.pytest.ini_options]

pyproject.toml

@@ -1,3 +1,6 @@
+from __future__ import annotations
+
+
 def test_import():
     import subprocess
     import time