add selective simulation capabilities to TerminalComponentModeler #2573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
6 files reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
Diff CoverageDiff: origin/develop...HEAD, staged and unstaged changes
Summary
|
dmarek-flex
force-pushed
the
dmarek/enable-select-excitations
branch
from
a7b7db5 to
27d92c1
Compare
dmarek-flex
force-pushed
the
dmarek/enable-select-excitations
branch
from
27d92c1 to
53d5cea
Compare
dmarek-flex
force-pushed
the
dmarek/enable-select-excitations
branch
from
53d5cea to
4d28758
Compare
weiliangjin2021
approved these changes
Jul 22, 2025
dmarek-flex
force-pushed
the
dmarek/enable-select-excitations
branch
from
4d28758 to
99c824b
Compare
|
Going to be conflicts with #2663, so I might wait for that to merge first. FYI @daquinteroflex |
|
Actually I'd argue it's probably better to merge this if it's ready and continue the refactor using this |
dmarek-flex
requested review from
daquinteroflex and
dbochkov-flexcompute
and removed request for
yaugenst-flex
dbochkov-flexcompute
approved these changes
Jul 28, 2025
dmarek-flex
force-pushed
the
dmarek/enable-select-excitations
branch
2 times, most recently
from
58b2a1f to
90948e6
Compare
refactored common code into AbstractComponentModeler add toggle for controlling how s matrix is calculated added validation of run_only and element_mappings for modelers
dmarek-flex
force-pushed
the
dmarek/enable-select-excitations
branch
from
90948e6 to
77339c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows the same approach as the
ComponentModelerwhere users can choose torun_onlya subset of simulations and also may provideelement_mappingsto fill in unknown entries in the S matrix using other known entries.The major difference is that the
coordsused in the final matrixDataArrayare flattened so I can mix different types of Ports (Lumped and Wave), where some support modes and others do not.Greptile Summary
Extends
TerminalComponentModelerwith selective simulation capabilities, enabling users to compute only specific S-matrix columns and derive missing elements through mapping relationships.run_onlyparameter toTerminalComponentModelerfor selectively computing S-matrix columns, reducing simulation timeelement_mappingsfeature to derive unknown S-matrix elements from known entriestest_terminal_component_modeler.pyvalidating selective simulations and mappings