Skip to content

Conversation

@lockshaw
Copy link
Collaborator

@lockshaw lockshaw commented Jan 18, 2025

Description of changes:

#1578 updated to a new version of proj that contained a bug in the proj build command, this commit updates nix-locked proj to version lockshaw/proj@e240046 which contains a fix.

Related Issues:

Linked Issues:

  • Issue #

Issues closed by this PR:

  • Closes #

Before merging:

  • Did you update the flexflow-third-party repo, if modifying any of the Cmake files, the build configs, or the submodules?

This change is Reviewable

@lockshaw lockshaw requested a review from victorli2002 January 18, 2025 00:59
@lockshaw lockshaw enabled auto-merge (squash) January 18, 2025 00:59
@codecov
Copy link

codecov bot commented Jan 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.47%. Comparing base (0a13572) to head (76293e0).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1580   +/-   ##
=======================================
  Coverage   60.47%   60.47%           
=======================================
  Files         606      606           
  Lines       14723    14723           
=======================================
  Hits         8903     8903           
  Misses       5820     5820           
Flag Coverage Δ
unittests 60.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Collaborator

@victorli2002 victorli2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me now 👍

@lockshaw lockshaw disabled auto-merge January 18, 2025 19:32
@lockshaw lockshaw merged commit d4a92da into flexflow:master Jan 18, 2025
9 of 10 checks passed
@lockshaw lockshaw deleted the fix-proj-build branch January 18, 2025 19:32
@victorli2002 victorli2002 mentioned this pull request Mar 12, 2025
@victorli2002 victorli2002 mentioned this pull request Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants