Update OctoMap to latest release (1.10.0)#659
Update OctoMap to latest release (1.10.0)#659SeanCurtis-TRI merged 34 commits intoflexible-collision-library:masterfrom
Conversation
Recent CI changes resulted in build errors with OctoMap 1.8. Update to the most recent release, and include a work-around for an install problem (OctoMap/octomap#445) and for OctoMap requesting an ancient and unsupported version of CMake. Fixes: flexible-collision-library#656
mwoehlke-kitware
force-pushed
the
update-octomap
branch
from
ab20b3f to
99b7bd7
Compare
|
You've unlocked failure modes. I've pushed something to help the linux build. The mac build is complaining that it's not getting a compiler that is at least C++14. I don't know why that might be. |
A counter that increments but serves no other role.
SeanCurtis-TRI
left a comment
SeanCurtis-TRI
left a comment
There was a problem hiding this comment.
Baby steps on ubuntu CI -- the uninitialized variable, once initialized, proved to be unused.
@SeanCurtis-TRI made 1 comment.
Reviewable status: 0 of 3 files reviewed, all discussions resolved.
SeanCurtis-TRI
left a comment
SeanCurtis-TRI
left a comment
There was a problem hiding this comment.
Re: ubuntu CI. You've unlocked an error I've been able to reproduce locally. Debug builds (against octomap) encounter a pile of linker errors. Bunch of missing FCL symbols. The library builds, but the tests fail to link against it (due to the missing symbols).
@SeanCurtis-TRI made 1 comment.
Reviewable status: 0 of 3 files reviewed, all discussions resolved.
Local experience suggests that this works against Release. However, in CI when Debug fails, it cancels all the other builds. So, let's see if temporarily removing Debug will let Release proceed to the end.
|
Ok, it looks like things pass Ubuntu in release build. Now what's going on with debug build? |
Go from null-defined value to empty string.
- Leave octomap unconditionally building as release - Forego the effort to pass compiler parameters to mac
1. FCL doesn't depend on octree's dynamicETD3d subproject; disable it. 2. Print out the version of FCL being used when configuring FCL.
SeanCurtis-TRI
left a comment
SeanCurtis-TRI
left a comment
There was a problem hiding this comment.
Woo hoo! Ubuntu CI passes.....
Mac still thinks it's compiling using not-so-modern C++.
@SeanCurtis-TRI made 1 comment.
Reviewable status: 0 of 7 files reviewed, all discussions resolved.
Change the reference to a fork and branch that addresses these issues.
On mac 15, we're getting Eigen version 5.0.1. A bridge too far.
|
Even more progress... The mac builds now get through configuration and build. There are four out of ~280 tests that fail. Now I just have to figure out what's going on with the failure. |
1. Loosen tolerance in capsule-capsule test (9.5e-7 missed the previous tolerance of 8.7e-7) 2. Change bad gtest assertions into good gtest assertions (ones that provide meaningful feedback upon failure).
SeanCurtis-TRI
force-pushed
the
update-octomap
branch
from
5416c9f to
a696435
Compare
SeanCurtis-TRI
merged commit e5efcc4
into
flexible-collision-library:master
2 participants
Recent CI changes resulted in build errors with OctoMap 1.8. Update to the most recent release, and include a work-around for an install problem (OctoMap/octomap#445).
Fixes: #656
This change is