mangoapp: pull engine from gamescope #1498
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pac85
force-pushed
the
gamescope_engine_master
branch
from
77b9b8d to
9483d28
Compare
pac85
force-pushed
the
gamescope_engine_master
branch
from
9483d28 to
b897ed7
Compare
Contributor
|
I've continued using this + the gamescope PR over the past weekend, and it was accurate in every instance I tried: VULKAN, VKD3D, DXVK, and Gamescope all were matched correctly in the mangoapp overlay. |
Comment on lines
+20
to
+22
| uint16_t displayRefresh; | ||
| bool bAppWantsHDR : 1; | ||
| bool bSteamFocused : 1; |
Contributor
There was a problem hiding this comment.
These additions (displayRefresh, bAppWantsHDR, bSteamFocused) seem unrelated to adding engine name. But it looks like gamespace has a different definition.
Author
There was a problem hiding this comment.
Yeah so the point was to sync it up with gamescope https://github.com/ValveSoftware/gamescope/blob/master/src/mangoapp.cpp#L31
Since I've added a field I had to add the fields before it as well.
Contributor
There was a problem hiding this comment.
Yeah, already through so.
pac85
force-pushed
the
gamescope_engine_master
branch
from
d9dd0ba to
2b2a20e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gamescope side: ValveSoftware/gamescope#1653
With that patch gamescope will use it's layer to pull
engineNamefromVkApplicationInfoand send it to mangoapp.This change will make it use that information, this allows to have the engineName displayed in a simpler way without MangoHud's layer.