feat(#187): fail-fast on Scala type resolution with Class #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
novakov-alexey
requested changes
Jan 28, 2025
Collaborator
novakov-alexey
left a comment
novakov-alexey
left a comment
There was a problem hiding this comment.
Thanks, looks good. Few minor things only.
modules/scala-api/src/main/scala/org/apache/flinkx/api/StreamExecutionEnvironment.scala
Outdated
Show resolved
Hide resolved
| * Pass a custom configuration into the cluster. | ||
| */ | ||
| def getExecutionEnvironment(configuration: Configuration): StreamExecutionEnvironment = { | ||
| configureFailFastOnScalaTypeResolutionWithClass(configuration) |
Collaborator
There was a problem hiding this comment.
Let's keep user's configuration: Configuration argument unchanged. There are no much benefits for user to know that we injected additional properties into the Configuration for that FailFastFactory.
…xtra() and make it side-effect free
Contributor
Author
|
Hi @novakov-alexey, |
modules/scala-api/src/main/scala/org/apache/flinkx/api/StreamExecutionEnvironment.scala
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @novakov-alexey,
Here is the PR discussed in issue #187.
About your questions in the issue:
pipeline.serialization-configproperty do nothing before Flink 1.19, so there is no need to drop support. When 1.18 support will be dropped, we'll be able to usePipelineOptions.SERIALIZATION_CONFIGconstant and simplify the test.Is the modification in the readme and explanations given by the exception clear enough to you?
Thanks