Use middle products in gr_mat_gr_poly_solve_lode_newton#2618
Merged
fredrik-johansson merged 2 commits intoflintlib:mainfrom Mar 22, 2026
Merged
Use middle products in gr_mat_gr_poly_solve_lode_newton#2618fredrik-johansson merged 2 commits intoflintlib:mainfrom
gr_mat_gr_poly_solve_lode_newton#2618fredrik-johansson merged 2 commits intoflintlib:mainfrom
Conversation
…mat_gr_poly_solve_lode_newton
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces some full or low operations with middle operations in
gr_mat_gr_poly_solve_lode_newton. This should speed things up, but should also improve accuracy with balls, since low coefficients in the Err matrix that are mathematically zero are now explicitly zeroed whereas they may previously have been set to inexact zeros.I have left TODO comments for the operations I noticed that remain to optimize (mainly because there is no matrix mulmid function available yet), but I may have missed some.