Use faster code for remainder by p in qsieve_evaluate_candidate#2626
Merged
fredrik-johansson merged 1 commit intoflintlib:mainfrom Apr 5, 2026
Merged
Use faster code for remainder by p in qsieve_evaluate_candidate#2626fredrik-johansson merged 1 commit intoflintlib:mainfrom
qsieve_evaluate_candidate#2626fredrik-johansson merged 1 commit intoflintlib:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The quadratic sieve spends a decent portion of its time in
qsieve_evaluate_candidatewhich checks the remainder of the candidateiby all factor base primes. There is maybe a better way to implement this function, but a trivial improvement is to replacen_mod2_preinvwith a Lemire-Kaser-Kurz remainder. This speeds up the quadratic sieve 5-20%.Time (single-threaded) to factor nextprime(10^n)*nextprime(10^(n+1)) with
fmpz_factor: