Split _truediv_scalar_ into two functions

Author: Jake Moss

src/flint/flint_base/flint_base.pxd

@@ -23,7 +23,8 @@ cdef class flint_mpoly(flint_elem):
     cdef _mul_mpoly_(self, other)
 
     cdef _divmod_mpoly_(self, other)
-    cdef _truediv_scalar_(self, other, assume_exact: bool)
+    cdef _truediv_scalar_(self, other)
+    cdef _divexact_scalar_(self, other)
     cdef _floordiv_mpoly_(self, other)
     cdef _truediv_mpoly_(self, other)
     cdef _mod_mpoly_(self, other)

src/flint/flint_base/flint_base.pyx

@@ -449,7 +449,10 @@ cdef class flint_mpoly(flint_elem):
     cdef _floordiv_mpoly_(self, other):
         return NotImplemented
 
-    cdef _truediv_scalar_(self, other, assume_exact: bool):
+    cdef _truediv_scalar_(self, other):
+        return NotImplemented
+
+    cdef _divexact_scalar_(self, other):
         return NotImplemented
 
     cdef _truediv_mpoly_(self, other):
@@ -611,7 +614,7 @@ cdef class flint_mpoly(flint_elem):
             return NotImplemented
 
         self._division_check(other)
-        res = self._truediv_scalar_(other, False)
+        res = self._truediv_scalar_(other)
         if res is not NotImplemented:
             return res
 

src/flint/types/fmpq_mpoly.pyx

@@ -420,13 +420,16 @@ cdef class fmpq_mpoly(flint_mpoly):
         fmpq_mpoly_div(quotient.val, self.val, other.val, self.ctx.val)
         return quotient
 
-    cdef _truediv_scalar_(self, arg, _: bool):
+    cdef _truediv_scalar_(self, arg):
         cdef fmpq_mpoly quotient
         cdef fmpq other = <fmpq>arg
         quotient = create_fmpq_mpoly(self.ctx)
         fmpq_mpoly_scalar_div_fmpq(quotient.val, self.val, other.val, self.ctx.val)
         return quotient
 
+    cdef _divexact_scalar_(self, arg):
+        return self._truediv_scalar_(arg)
+
     cdef _truediv_mpoly_(self, arg):
         cdef fmpq_mpoly quotient, other = <fmpq_mpoly>arg
         quotient = create_fmpq_mpoly(self.ctx)

src/flint/types/fmpz_mpoly.pyx

@@ -405,19 +405,22 @@ cdef class fmpz_mpoly(flint_mpoly):
         fmpz_mpoly_div(quotient.val, self.val, other.val, self.ctx.val)
         return quotient
 
-    cdef _truediv_scalar_(self, arg, assume_exact: bool):
+    cdef _truediv_scalar_(self, arg):
         cdef fmpz_mpoly quotient,
         cdef fmpz other = <fmpz>arg
         quotient = create_fmpz_mpoly(self.ctx)
-        if assume_exact:
-            fmpz_mpoly_scalar_divexact_fmpz(quotient.val, self.val, other.val, self.ctx.val)
-            return quotient
-
         if fmpz_mpoly_scalar_divides_fmpz(quotient.val, self.val, other.val, self.ctx.val):
             return quotient
         else:
             raise DomainError("fmpz_mpoly division is not exact")
 
+    cdef _divexact_scalar_(self, arg):
+        cdef fmpz_mpoly quotient,
+        cdef fmpz other = <fmpz>arg
+        quotient = create_fmpz_mpoly(self.ctx)
+        fmpz_mpoly_scalar_divexact_fmpz(quotient.val, self.val, other.val, self.ctx.val)
+        return quotient
+
     cdef _truediv_mpoly_(self, arg):
         cdef fmpz_mpoly quotient, other = <fmpz_mpoly>arg
         quotient = create_fmpz_mpoly(self.ctx)
@@ -865,7 +868,7 @@ cdef class fmpz_mpoly(flint_mpoly):
             (2, x0*x1 + 2*x0)
         """
         cdef fmpz content = self.content()
-        return content, self._truediv_scalar_(content, True)
+        return content, self._divexact_scalar_(content)
 
     def sqrt(self, assume_perfect_square: bool = False):
         """