Josh rustup #8
Open
Josh rustup #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flip1995
force-pushed
the
josh-automation
branch
5 times, most recently
from
3f6693b to
3957dad
Compare
flip1995
force-pushed
the
josh-rustup
branch
2 times, most recently
from
8c23274 to
13f01a7
Compare
flip1995
force-pushed
the
josh-automation
branch
2 times, most recently
from
fd562d8 to
01904b0
Compare
flip1995
force-pushed
the
josh-automation
branch
from
852fc21 to
7808dbc
Compare
This fixes an issue where clippy suggests passing a function that takes no arguments as the first argument of `Result::map_or_else`. The function needs to take one argument. Example that triggers the issue: [Playground link](https://play.rust-lang.org/?version=nightly&mode=debug&edition=2021&gist=0b6f9bc7b6ab4dcd26745065544e0b8a) Fixes rust-lang#10335. changelog: [`option_if_let_else`]: fix incorrect suggestion when the contents of an `Err` variant are ignored
The feature freeze period is over. changelog: none
ping rust-lang#15690 changelog: none
`.unwrap_or(vec![])` is as readable as `.unwrap_or_default()`.
…ang#15699) `.unwrap_or(vec![])` is as readable as `.unwrap_or_default()`. Also, this ensures by adding tests that expressions such as `.unwrap_or(DEFAULT_LITERAL)` (`0`, `""`, etc.) are not replaced by `.unwrap_or_default()` either. Related to the discussion in the [Zulip discussion](https://rust-lang.zulipchat.com/#narrow/channel/257328-clippy/topic/FCP.20concealed_obvious_default) about PR rust-lang#15037. changelog: [`unwrap_or_default`]: do not replace `.unwrap_or(vec![])` by `.unwrap_or_default()`
…rust-lang#15277) Needed to split the lints crate. changelog: split `redundant_clone` iterator checks into `redundant_iter_cloned` <!-- TRIAGEBOT_START --> <!-- TRIAGEBOT_SUMMARY_START --> ### Summary Notes - [Feature-freeze](rust-lang#15277 (comment)) by [github-actions[bot]](https://github.com/github-actions[bot]) *Managed by `@rustbot`—see [help](https://forge.rust-lang.org/triagebot/note.html) for details* <!-- TRIAGEBOT_SUMMARY_END --> <!-- TRIAGEBOT_END -->
r? @ghost changelog: none
Clippy subtree update r? `@Manishearth` `Cargo.lock` update due to release/Clippy version bump.
Co-authored-by: Anne Stijns <[email protected]>
Port #[macro_export] to the new attribute parsing infrastructure Ports macro_export to the new attribute parsing infrastructure for rust-lang/rust#131229 (comment) r? ``@oli-obk`` cc ``@JonathanBrouwer`` ``@jdonszelmann``
Rollup of 4 pull requests Successful merges: - rust-lang/rust#143857 (Port #[macro_export] to the new attribute parsing infrastructure) - rust-lang/rust#146486 (Improve `core::sync::atomic` coverage) - rust-lang/rust#146606 (ci: x86_64-gnu-tools: Add `--test-args` regression test) - rust-lang/rust#146639 (std: merge definitions of `StdioPipes`) r? `@ghost` `@rustbot` modify labels: rollup
flip1995
force-pushed
the
josh-automation
branch
from
fac5ad5 to
c330004
Compare
Now that JOSH is used to sync, it is much easier to script the sync process. This introduces the two commands `sync pull` and `sync push`. The first one will pull changes from the Rust repo, the second one will push the changes to the Rust repo. For details, see the documentation in the book.
This is a QoL improvement for doing releases. The `release bump_version` subcommand increments the version in all relevant `Cargo.toml` files. The `release commit` command will only work with the new Josh syncs. Until then the old way, using `git log` has to be used.
flip1995
force-pushed
the
josh-automation
branch
from
c330004 to
85f5f2b
Compare
flip1995
force-pushed
the
josh-rustup
branch
from
89f1145 to
c1bccb6
Compare
flip1995
force-pushed
the
josh-automation
branch
from
85f5f2b to
19c34d4
Compare
flip1995
force-pushed
the
josh-automation
branch
2 times, most recently
from
c1cfd61 to
8742769
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: none