Skip to content

NFC: Fix sending 32+ byte ISO 15693-3 commands#4333

Open
WillyJL wants to merge 1 commit intoflipperdevices:devfrom
WillyJL:fix/iso15693-frame-buf-size
Open

NFC: Fix sending 32+ byte ISO 15693-3 commands#4333
WillyJL wants to merge 1 commit intoflipperdevices:devfrom
WillyJL:fix/iso15693-frame-buf-size

Conversation

@WillyJL
Copy link
Contributor

@WillyJL WillyJL commented Jan 23, 2026

What's new

  • fixes sending 32+ byte ISO 15693-3 commands, now allows up to 64 bytes
  • all other layers aim for a max of 64 bytes, this was a small mistake multiplying the byte count by 2 instead of by 4: as stated by the nearby comment too, each data bit encodes to 4 bits, not 2

Verification

  • [ Describe how to verify changes ]

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

Copy link

@ch4istO ch4istO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are working correctly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants