fix HID limits to support international keyboards#4361
Open
d3npa wants to merge 2 commits intoflipperdevices:devfrom
Open
fix HID limits to support international keyboards#4361d3npa wants to merge 2 commits intoflipperdevices:devfrom
d3npa wants to merge 2 commits intoflipperdevices:devfrom
Conversation
Author
|
I added my new keyboard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was having trouble sending pipe characters in badusb with my jp-106 key layout and it seems the reason was the limits set on the HID descriptor. The pipe character is typed with Shift+Yen, which sends a 0x89 keycode (outside the current upstream limit of dec 101 / 0x65). Backslash
\(0x87, Ro key) and underscore_(Shift+0x87) were also affected for the same reason. The computer silently drops keycodes outside the range declared in the descriptor, so these characters never arrived.What's new
LOGICAL_MAXIMUMandUSAGE_MAXIMUMare raised to 255 to allow keycodes above 101 from international keyboards.Verification
/badusb/assets/layouts/ja-JP.kl(script by Claude Opus 4.6)jis-test.txtin BadUSB (make sure to selectja-JPlayout)Checklist (For Reviewer)