NFC: Fix BusFault in Write to Initial Card#4362
Open
akrylysov wants to merge 1 commit intoflipperdevices:devfrom
Open
NFC: Fix BusFault in Write to Initial Card#4362akrylysov wants to merge 1 commit intoflipperdevices:devfrom
akrylysov wants to merge 1 commit intoflipperdevices:devfrom
Conversation
mode_ctx is a union where write_ctx.tag_block overlaps with dict_attack_ctx.nested_nonce.nonces. In "Write to Initial Card" it causes mf_classic_poller_free calling free on a garbage pointer
akrylysov
requested review from
DrZlo13,
gornekich,
gsurkov and
hedger
as code owners
This was referenced Mar 22, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new
Fixes #4108.
mode_ctxis a union wherewrite_ctx.tag_blockoverlaps withdict_attack_ctx.nested_nonce.nonces. In "Write to Initial Card" it causesmf_classic_poller_freecallingfree()on a garbage pointer.Verification
Built the firmware with the fix and tested with a key fob and an nfc file that caused a crash.
Checklist (For Reviewer)