Enable DVFS for Rockchip boards #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alchark
requested changes
Jan 20, 2026
Comment on lines
+37
to
+39
| #ifdef CONFIG_DM_DVFS | ||
| #include <dvfs.h> | ||
| #endif |
Collaborator
There was a problem hiding this comment.
No conditionals around headers usually
| #endif | ||
|
|
||
| #ifdef CONFIG_DM_DVFS | ||
| dvfs_init(true); |
Collaborator
There was a problem hiding this comment.
This doesn't do anything without a driver, does it? If so, this commit should go after the one that adds a driver to make it work.
Comment on lines
+26
to
+28
| * These are vendor-specific properties from rk3576 vendor kernel DTS | ||
| * that upstream kernel doesn't have. U-Boot DVFS driver needs them. | ||
| * |
Collaborator
There was a problem hiding this comment.
This sounds like additional functionality that is probably better to drop on the first submission to make everything more reviewable. Vendor specific extensions are harder to justify
Change-Id: bc5190ad-cd3b-43fc-9127-930354102e1b Signed-off-by: Anton Burticica <mouse@ya.ru>
ya-mouse
force-pushed
the
splram-0c52a9d2
branch
from
8a8265c to
6790f6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: bc5190ad-cd3b-43fc-9127-930354102e1b