fastboot: Add "fastboot device" command for runtime block device selection #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ya-mouse
changed the title
alchark
requested changes
Jan 20, 2026
Comment on lines
+18
to
+20
| #if CONFIG_IS_ENABLED(FASTBOOT_FLASH_BLOCK) | ||
| #include <fb_block.h> | ||
| #endif |
Collaborator
There was a problem hiding this comment.
No conditionals around headers usually
Comment on lines
+226
to
+231
| #if IS_ENABLED(CONFIG_TCP_FUNCTION_FASTBOOT) | ||
| " | tcp" | ||
| #endif | ||
| #if IS_ENABLED(CONFIG_UDP_FUNCTION_FASTBOOT) | ||
| " | udp" | ||
| #endif |
Collaborator
There was a problem hiding this comment.
What does checkpatch.pl think about all this beauty? :)
Comment on lines
+15
to
+23
| /** | ||
| * fastboot_block_interface - runtime block interface name | ||
| */ | ||
| static char fastboot_block_interface[16]; | ||
|
|
||
| /** | ||
| * fastboot_block_device - runtime block device ID | ||
| */ | ||
| static int fastboot_block_device = -1; |
Collaborator
There was a problem hiding this comment.
Any way to achieve this without global variables?
| { | ||
| if (*fastboot_block_interface) | ||
| return fastboot_block_interface; | ||
| return config_opt_enabled(CONFIG_FASTBOOT_FLASH_BLOCK, |
Collaborator
There was a problem hiding this comment.
Empty line between an if statement and the following code
| { | ||
| if (fastboot_block_device >= 0) | ||
| return fastboot_block_device; | ||
| return config_opt_enabled(CONFIG_FASTBOOT_FLASH_BLOCK, |
ya-mouse
force-pushed
the
splram-f75e21fc
branch
2 times, most recently
from
cb1565d to
9cc3c2d
Compare
…ction Add the ability to change the fastboot flash target device at runtime without recompiling. This is useful for: - Platforms with multiple storage options (eMMC + UFS + NVMe) - Development and testing scenarios - Recovery situations where the default device is unavailable New command syntax: fastboot device <interface> <dev> - set flash interface and device fastboot device - show current interface and device Implementation details: - Add fastboot_block_set_interface() and fastboot_block_set_device() functions to set runtime values - Add fastboot_block_get_interface() and fastboot_block_get_device() getters that return runtime value if set, otherwise fall back to Kconfig defaults - Update fb_block.c to use the new getter functions - Add command handler gated by CONFIG_FASTBOOT_FLASH_BLOCK Example usage: => fastboot device scsi 0 Set fastboot block interface to 'scsi', device to 0 => fastboot usb 0 (now flashing targets SCSI device 0 instead of default) Change-Id: 7b54f839-5659-4aaf-b58f-d6107e08a24d Signed-off-by: Anton Burticica <mouse@ya.ru>
ya-mouse
force-pushed
the
splram-f75e21fc
branch
from
9cc3c2d to
7b9f96a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to change the fastboot flash target device at runtime without recompiling. This is useful for:
New command syntax:
fastboot device - set flash interface and device
fastboot device - show current interface and device
Implementation details:
Example usage:
=> fastboot device scsi 0 Set fastboot block interface to 'scsi', device to 0 => fastboot usb 0 (now flashing targets SCSI device 0 instead of default)
Change-Id: 7b54f839-5659-4aaf-b58f-d6107e08a24d