cpu: armv8: Add Cortex-A5x/A7x CPU support and enhance driver functionality #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ya-mouse
force-pushed
the
batch-01
branch
7 times, most recently
from
0215158 to
323f48d
Compare
alchark
reviewed
Jan 19, 2026
Collaborator
There was a problem hiding this comment.
This change should be a separate patch for upstreaming, and it goes into arch/arm/dts (as an appropriate U-boot specific .dtsi file), not dts/upstream.
Or better yet - make it work in OTG mode, which this particular port really is at the hardware level (and also board markings)
alchark
reviewed
Jan 19, 2026
| /* Disable USB3OTG0 U3 port, later enabled by USBDP PHY driver */ | ||
| writel(0xffff0188, USB_GRF_BASE + USB3OTG0_CON1); | ||
| if (read_brom_bootsource_id() == BROM_BOOTSOURCE_USB) { | ||
| writel(0x00200020, TOP_CRU_BASE + TOP_CRU_SOFTRST_CON47); |
Collaborator
There was a problem hiding this comment.
Can we add #define's for the bits here?
alchark
reviewed
Jan 19, 2026
| udelay(1000); | ||
| writel(0x00200000, TOP_CRU_BASE + TOP_CRU_SOFTRST_CON47); | ||
| udelay(1000); | ||
| writel(0x000c0008, USB_GRF_BASE + USB3OTG0_CON1); |
Collaborator
There was a problem hiding this comment.
Ditto. Otherwise it's hard to comprehend why the value here is different from the one under "else"
alchark
reviewed
Jan 19, 2026
Collaborator
There was a problem hiding this comment.
Why is it needed now, but hasn't been needed before? Please describe in the commit message what issue this addresses
alchark
reviewed
Jan 19, 2026
Collaborator
There was a problem hiding this comment.
Is this purely cosmetic / informational, or do we use this anywhere down the line?
ya-mouse
force-pushed
the
batch-01
branch
2 times, most recently
from
9793cd5 to
4fed021
Compare
ya-mouse
changed the title
…nality Extend the ARMv8 CPU driver with the following improvements: 1. Add compatible strings for modern ARM Cortex-A cores: - arm,cortex-a53 - arm,cortex-a55 - arm,cortex-a72 - arm,cortex-a73 - arm,cortex-a75 - arm,cortex-a76 2. Implement human-readable CPU name detection by reading the MIDR register and mapping known part numbers to descriptive names. 3. Add clock frequency reporting via the clk framework. The driver now probes for an optional clock and reports the CPU frequency in cpu_get_info() when available. 4. Implement get_vendor() callback returning "ARM" as the vendor. 5. Implement is_current() callback that compares the MPIDR register value against the device tree "reg" property to identify if this CPU device corresponds to the currently executing CPU. 6. Add private data structure to track per-CPU state including the optional clock reference. These changes enable proper CPU enumeration and information display on SoCs using Cortex-A5x and Cortex-A7x cores, which are common in modern Rockchip, NXP, and other ARM-based platforms. Change-Id: 6372f41d-a192-4117-9c1a-b5c75db2617a batch-01 Signed-off-by: Anton Burticica <mouse@ya.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the ARMv8 CPU driver with the following improvements:
Add compatible strings for modern ARM Cortex-A cores:
Implement human-readable CPU name detection by reading the MIDR
register and mapping known part numbers to descriptive names.
Add clock frequency reporting via the clk framework. The driver
now probes for an optional clock and reports the CPU frequency
in cpu_get_info() when available.
Implement get_vendor() callback returning "ARM" as the vendor.
Implement is_current() callback that compares the MPIDR register
value against the device tree "reg" property to identify if this
CPU device corresponds to the currently executing CPU.
Add private data structure to track per-CPU state including the
optional clock reference.
These changes enable proper CPU enumeration and information display
on SoCs using Cortex-A5x and Cortex-A7x cores, which are common in
modern Rockchip, NXP, and other ARM-based platforms.
Change-Id: 6372f41d-a192-4117-9c1a-b5c75db2617a batch-01