Skip to content

feat: add stdout option to print and format option to switch around json/yaml #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skarim merged 3 commits into from
Jun 6, 2025
Merged

feat: add stdout option to print and format option to switch around json/yaml #7

skarim merged 3 commits into from
Jun 6, 2025

Conversation

@ahnopologetic
Copy link
Contributor

@ahnopologetic ahnopologetic commented Jun 1, 2025

Depends on #6

  • Adding options --format and --stdout
  • Editing README.md

@ahnopologetic ahnopologetic marked this pull request as ready for review June 1, 2025 19:27
@skarim skarim added the enhancement New feature or request label Jun 2, 2025
skarim
skarim previously approved these changes Jun 4, 2025
View reviewed changes
Copy link
Contributor

@skarim skarim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀
waiting to merge until #6 is updated and this is rebased with any changes there

@skarim skarim added this to the 0.7.4 milestone Jun 4, 2025
@skarim
Copy link
Contributor

skarim commented Jun 5, 2025

@ahnopologetic can you please rebase this with main?

@ahnopologetic
Copy link
Contributor Author

ahnopologetic commented Jun 5, 2025

Uhoh wrong github account

@ahnopologetic ahnopologetic force-pushed the feature/output-json branch from db637d2 to 66c09e8 Compare June 5, 2025 23:34
@ahnopologetic ahnopologetic requested a review from skarim June 5, 2025 23:35
skarim
skarim approved these changes Jun 6, 2025
View reviewed changes
Copy link
Contributor

@skarim skarim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @ahnopologetic!

@skarim skarim merged commit e4d42b8 into fliskdata:main Jun 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skarim skarim skarim approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

0.7.4

Development

Successfully merging this pull request may close these issues.

2 participants

@ahnopologetic @skarim