Skip to content

Conversation

@merkuns
Copy link
Collaborator

@merkuns merkuns commented May 22, 2025

…ertain hyperparameters

Added file test_ude_optimization.py that consistently throws an EquinoxRuntimeError even with max_steps=1000000 (at least on my computer). Also made changes to pyproject.toml to reflect the need to install optax. (Edit: Removed that again because it creates the issues described in #143 )

@merkuns merkuns added the testing Make or write tests to cover the package label May 22, 2025
@merkuns
Copy link
Collaborator Author

merkuns commented May 26, 2025

I updated the file because I made some small changes to the model formulation and because I found out that theta_true was being modified by the optimizer (somehow I tricked myself into believing it wasn't being changed even though it never made sense) which had to be ruled out (for now).

Now the RuntimeError happens much earlier which is probably a good thing for the debugging process.

@flo-schu flo-schu changed the base branch from main to dev June 5, 2025 10:07
@flo-schu flo-schu changed the base branch from dev to main June 5, 2025 23:13
@flo-schu flo-schu changed the base branch from main to dev June 5, 2025 23:14
@flo-schu flo-schu force-pushed the test-ude-optimization branch from 76c551b to 52f2cec Compare June 5, 2025 23:59
…ertain hyperparameters

Update with some minor changes to the model formulation and some necessary changes to the optimization process

Changed the way updates to theta_true are being prevented to a much simpler one
@flo-schu flo-schu force-pushed the test-ude-optimization branch from 52f2cec to 98c925f Compare June 6, 2025 00:05
@flo-schu flo-schu marked this pull request as draft June 6, 2025 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Make or write tests to cover the package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant