Skip to content

Conversation

@flo-schu
Copy link
Owner

@flo-schu flo-schu commented Jul 2, 2025

  • Catch error of differently shaped batch dimensions (fixes #154)

+ iterates over the coordinates_input_vars and looks for coordinates that are different from the observations batch coordinates.
@flo-schu flo-schu requested a review from mariegrho July 2, 2025 13:20
@flo-schu flo-schu linked an issue Jul 2, 2025 that may be closed by this pull request
@flo-schu flo-schu modified the milestones: Release 0.7.0, Release 0.6.0 Jul 2, 2025
@flo-schu flo-schu moved this to In progress in pymob-roadmap Jul 2, 2025
@flo-schu
Copy link
Owner Author

flo-schu commented Jul 2, 2025

Hi @mariegrho if you find time, you could review the error message, which fixes an error that we had discovered in mempyguts. If everything makes sense to you, you could go ahead and catch the errors in #154 and write PymobErrors with informative error messages.

@flo-schu flo-schu marked this pull request as draft July 3, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

1 participant