Merged
Conversation
see #1947 Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reverts logging to IndexedDB and instead saves logs using a new local-storage based approach.
- Logger.log now accumulates formatted log messages in a static array instead of writing to IndexedDB.
- New persist and getLogs methods in Logger load platform-specific storage modules to write/read logs from alternative storage.
- IndexedDB-related functionality in IndexedDB.ts is reduced, and Logger.persist is now invoked in Account.ts to save log data.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/lib/Logger.js | Removed direct IndexedDB logging; now pushes messages locally and persists them via platform-specific storage. |
| src/lib/IndexedDB.ts | Removed freeStorageIfNecessary logic and added a call to delete the IndexedDB on load. |
| src/lib/Account.ts | Added calls to Logger.persist after logging events to ensure logs are saved. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #1947