fix: fixed calculation of differences#74
Draft
manuba95 wants to merge 2 commits intofloodlight-sports:developfrom
Draft
fix: fixed calculation of differences#74manuba95 wants to merge 2 commits intofloodlight-sports:developfrom
manuba95 wants to merge 2 commits intofloodlight-sports:developfrom
Conversation
Contributor
|
Hi, thanks for pointing this out. As we are having similar considerations in the filter functions or ApEn calculation, I think this requires a bigger refactor for So I'm making this a draft for now and put this on the priority list for the next major update! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the unwanted behavior of the numpy gradient and diff functions to replace the first/last value of a NaN-free sequence with a NaNs. The differentiated data now has values where the original data has values and vice versa. This is achieved by the same approach we used to get the filterable sequences for the low pass filter.
Additionally, a minor bug in the call of the numpy diff function was fixed.