Null replaceValue and multiLine findRegex processing. #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed "required" attribute of "replaceValue" parameter. Empty String replacement for null "replaceValue" parameter added at ProcessFilesTask.processFileContents. ProcessFilesTask.processFileContents method was modified to achieve multiline findRegex processing. Corresponding tests were added: * FindAndReplaceMojoTest.testFileContentsMultiLineRegex * FindAndReplaceMojoTest.testFileContentsMultiLineRegex2 Removed redundant toUri() calls at several tests.
# Conflicts: # src/main/java/io/github/floverfelt/find/and/replace/maven/plugin/tasks/ProcessFilesTask.java
Test method regexFileContains added.
|
I find this change very useful. However, I encountered an issue with it: when performing a find-and-replace on executable files, this execution does not preserve the executable bit. |
Author
@bherw Thanks for your response. As far as I can tell, this behavior with the execution bit is also typical for the parent code, isn't it? |
…ndant ones in tests. The verification and application of access rights has been changed to POSIX-compatible, the previous approach was erroneous. The verification and application of access attributes is omitted for non-posix compliant operating systems. The relevant tests have been implemented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed "required" attribute of "replaceValue" parameter.
Empty String replacement for null "replaceValue" parameter added at ProcessFilesTask.processFileContents.
ProcessFilesTask.processFileContents method was modified to achieve multiline findRegex processing.
Corresponding tests were added:
Removed redundant toUri() calls at several tests.