Skip to content

Add testing against PHP 8.4 #1257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
norberttech merged 3 commits into from
Nov 22, 2024
Merged

Add testing against PHP 8.4 #1257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
27b59b2
Add testing against PHP 8.4
stloyd Nov 20, 2024
4512988
Fixed test for PHP 8.4 (in previous PHP version bug returns invalid r…
stloyd Nov 22, 2024
b4b3a0a
Fixed deprecation from PHP 8.4
stloyd Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/test-extensions.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ jobs:
- "8.1"
- "8.2"
- "8.3"
- "8.4"
operating-system:
- "ubuntu-latest"

Expand Down Expand Up @@ -99,4 +100,4 @@ jobs:
run: "composer test -- --group zstd-extension"

- name: "Test Snappy"
run: "composer test -- --group snappy-extension"
run: "composer test -- --group snappy-extension"
1 change: 1 addition & 0 deletions .github/workflows/test-suite.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ jobs:
- "8.1"
- "8.2"
- "8.3"
- "8.4"
operating-system:
- "ubuntu-latest"

Expand Down
4 changes: 2 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"load"
],
"require": {
"php": "~8.1.0 || ~8.2.0 || ~8.3.0",
"php": "~8.1.0 || ~8.2.0 || ~8.3.0 || ~8.4.0",
"ext-bcmath": "*",
"ext-dom": "*",
"ext-hash": "*",
Expand All @@ -25,7 +25,7 @@
"doctrine/dbal": "^3.6 || ^4.0",
"elasticsearch/elasticsearch": "^7.6|^8.0",
"google/apiclient": "^2.13",
"halaxa/json-machine": "^1.0",
"halaxa/json-machine": "^1.1",
"jawira/case-converter": "^3.4",
"meilisearch/meilisearch-php": "^1.1",
"monolog/monolog": "^2.0||^3.0",
Expand Down
18 changes: 9 additions & 9 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/adapter/etl-adapter-avro/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"adapter"
],
"require": {
"php": "~8.1.0 || ~8.2.0 || ~8.3.0",
"php": "~8.1.0 || ~8.2.0 || ~8.3.0 || ~8.4.0",
"ext-json": "*",
"flow-php/etl": "^0.10.0 || 1.x-dev"
},
Expand Down
2 changes: 1 addition & 1 deletion src/adapter/etl-adapter-chartjs/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"adapter"
],
"require": {
"php": "~8.1.0 || ~8.2.0 || ~8.3.0",
"php": "~8.1.0 || ~8.2.0 || ~8.3.0 || ~8.4.0",
"flow-php/etl": "^0.10.0 || 1.x-dev"
},
"config": {
Expand Down
2 changes: 1 addition & 1 deletion src/adapter/etl-adapter-csv/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"adapter"
],
"require": {
"php": "~8.1.0 || ~8.2.0 || ~8.3.0",
"php": "~8.1.0 || ~8.2.0 || ~8.3.0 || ~8.4.0",
"flow-php/etl": "^0.10.0 || 1.x-dev"
},
"config": {
Expand Down
2 changes: 1 addition & 1 deletion src/adapter/etl-adapter-csv/src/Flow/ETL/Adapter/CSV/Detector/Option.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ public function isValid() : bool

public function parse(string $line) : void
{
$this->rows[] = \str_getcsv($line, $this->separator, $this->enclosure);
$this->rows[] = \str_getcsv($line, $this->separator, $this->enclosure, '\\');
}

public function reset() : self
Expand Down
2 changes: 1 addition & 1 deletion src/adapter/etl-adapter-csv/tests/Flow/ETL/Adapter/CSV/Tests/Integration/CSVDetectorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ private function createResource(string $separator = ',', string $enclosure = '"'
$resource = \fopen('php://memory', 'rb+');

foreach ($data as $line) {
\fputcsv($resource, $line, $separator, $enclosure);
\fputcsv($resource, $line, $separator, $enclosure, '\\');
}

$csv = \stream_get_contents($resource, offset: 0);
Expand Down
2 changes: 1 addition & 1 deletion src/adapter/etl-adapter-doctrine/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"loader"
],
"require": {
"php": "~8.1.0 || ~8.2.0 || ~8.3.0",
"php": "~8.1.0 || ~8.2.0 || ~8.3.0 || ~8.4.0",
"doctrine/dbal": "^3.6 || ^4.0",
"flow-php/doctrine-dbal-bulk": "^0.10.0 || 1.x-dev",
"flow-php/etl": "^0.10.0 || 1.x-dev"
Expand Down
2 changes: 1 addition & 1 deletion src/adapter/etl-adapter-elasticsearch/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"adapter"
],
"require": {
"php": "~8.1.0 || ~8.2.0 || ~8.3.0",
"php": "~8.1.0 || ~8.2.0 || ~8.3.0 || ~8.4.0",
"ext-hash": "*",
"ext-json": "*",
"elasticsearch/elasticsearch": "^7.6|^8.0",
Expand Down
2 changes: 1 addition & 1 deletion src/adapter/etl-adapter-google-sheet/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"adapter"
],
"require": {
"php": "~8.1.0 || ~8.2.0 || ~8.3.0",
"php": "~8.1.0 || ~8.2.0 || ~8.3.0 || ~8.4.0",
"flow-php/etl": "^0.10.0 || 1.x-dev",
"google/apiclient": "^2.13"
},
Expand Down
2 changes: 1 addition & 1 deletion src/adapter/etl-adapter-http/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"http"
],
"require": {
"php": "~8.1.0 || ~8.2.0 || ~8.3.0",
"php": "~8.1.0 || ~8.2.0 || ~8.3.0 || ~8.4.0",
"ext-json": "*",
"flow-php/etl": "^0.10.0 || 1.x-dev",
"psr/http-client": "^1.0"
Expand Down
4 changes: 2 additions & 2 deletions src/adapter/etl-adapter-json/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@
"adapter"
],
"require": {
"php": "~8.1.0 || ~8.2.0 || ~8.3.0",
"php": "~8.1.0 || ~8.2.0 || ~8.3.0 || ~8.4.0",
"ext-json": "*",
"flow-php/etl": "^0.10.0 || 1.x-dev",
"halaxa/json-machine": "^1.0"
"halaxa/json-machine": "^1.1"
},
"config": {
"optimize-autoloader": true,
Expand Down
2 changes: 1 addition & 1 deletion src/adapter/etl-adapter-logger/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"psr"
],
"require": {
"php": "~8.1.0 || ~8.2.0 || ~8.3.0",
"php": "~8.1.0 || ~8.2.0 || ~8.3.0 || ~8.4.0",
"flow-php/etl": "^0.10.0 || 1.x-dev",
"psr/log": "^2.0 || ^3.0"
},
Expand Down
2 changes: 1 addition & 1 deletion src/adapter/etl-adapter-meilisearch/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"adapter"
],
"require": {
"php": "~8.1.0 || ~8.2.0 || ~8.3.0",
"php": "~8.1.0 || ~8.2.0 || ~8.3.0 || ~8.4.0",
"ext-hash": "*",
"ext-json": "*",
"meilisearch/meilisearch-php": "^1.1",
Expand Down
2 changes: 1 addition & 1 deletion src/adapter/etl-adapter-parquet/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"adapter"
],
"require": {
"php": "~8.1.0 || ~8.2.0 || ~8.3.0",
"php": "~8.1.0 || ~8.2.0 || ~8.3.0 || ~8.4.0",
"ext-json": "*",
"flow-php/etl": "^0.10.0 || 1.x-dev",
"flow-php/parquet": "^0.10.0 || 1.x-dev"
Expand Down
2 changes: 1 addition & 1 deletion src/adapter/etl-adapter-text/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"adapter"
],
"require": {
"php": "~8.1.0 || ~8.2.0 || ~8.3.0",
"php": "~8.1.0 || ~8.2.0 || ~8.3.0 || ~8.4.0",
"flow-php/etl": "^0.10.0 || 1.x-dev"
},
"config": {
Expand Down
2 changes: 1 addition & 1 deletion src/adapter/etl-adapter-xml/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"adapter"
],
"require": {
"php": "~8.1.0 || ~8.2.0 || ~8.3.0",
"php": "~8.1.0 || ~8.2.0 || ~8.3.0 || ~8.4.0",
"ext-dom": "*",
"ext-xml": "*",
"ext-xmlreader": "*",
Expand Down
1 change: 0 additions & 1 deletion src/adapter/etl-adapter-xml/src/Flow/ETL/Adapter/XML/XMLParserExtractor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,6 @@ private function parser() : \XMLParser
if ($this->parser === null) {
$this->parser = xml_parser_create();
xml_parser_set_option($this->parser, XML_OPTION_CASE_FOLDING, 0);
xml_set_object($this->parser, $this);
xml_set_element_handler($this->parser, [$this, 'startElementHandler'], [$this, 'endElementHandler']);
xml_set_character_data_handler($this->parser, [$this, 'characterDataHandler']);
}
Expand Down
2 changes: 1 addition & 1 deletion src/bridge/filesystem/azure/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"cloud"
],
"require": {
"php": "~8.1.0 || ~8.2.0 || ~8.3.0",
"php": "~8.1.0 || ~8.2.0 || ~8.3.0 || ~8.4.0",
"flow-php/filesystem": "^0.10.0 || 1.x-dev",
"flow-php/azure-sdk": "^0.10.0 || 1.x-dev"
},
Expand Down
2 changes: 1 addition & 1 deletion src/bridge/monolog/http/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"bridge"
],
"require": {
"php": "~8.1.0 || ~8.2.0 || ~8.3.0",
"php": "~8.1.0 || ~8.2.0 || ~8.3.0 || ~8.4.0",
"monolog/monolog": "^2.0||^3.0",
"psr/http-message": "^1.0 || ^2.0"
},
Expand Down
2 changes: 1 addition & 1 deletion src/bridge/symfony/http-foundation/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"response"
],
"require": {
"php": "~8.1.0 || ~8.2.0 || ~8.3.0",
"php": "~8.1.0 || ~8.2.0 || ~8.3.0 || ~8.4.0",
"symfony/http-foundation": "~5.4.0 || ~6.4.0 || ~7",
"flow-php/etl": "^0.10.0 || 1.x-dev"
},
Expand Down
2 changes: 1 addition & 1 deletion src/cli/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"cli"
],
"require": {
"php": "~8.1.0 || ~8.2.0 || ~8.3.0",
"php": "~8.1.0 || ~8.2.0 || ~8.3.0 || ~8.4.0",
"symfony/console": "^5.4 || ^6.4 || ^7.0",
"flow-php/etl": "^0.10.0 || 1.x-dev",
"flow-php/etl-adapter-csv": "^0.10.0 || 1.x-dev",
Expand Down
2 changes: 1 addition & 1 deletion src/core/etl/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"load"
],
"require": {
"php": "~8.1.0 || ~8.2.0 || ~8.3.0",
"php": "~8.1.0 || ~8.2.0 || ~8.3.0 || ~8.4.0",
"ext-json": "*",
"ext-mbstring": "*",
"flow-php/array-dot": "^0.10.0 || 1.x-dev",
Expand Down
2 changes: 1 addition & 1 deletion src/lib/array-dot/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"dot"
],
"require": {
"php": "~8.1.0 || ~8.2.0 || ~8.3.0"
"php": "~8.1.0 || ~8.2.0 || ~8.3.0 || ~8.4.0"
},
"config": {
"optimize-autoloader": true,
Expand Down
2 changes: 1 addition & 1 deletion src/lib/azure-sdk/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"gcp"
],
"require": {
"php": "~8.1.0 || ~8.2.0 || ~8.3.0",
"php": "~8.1.0 || ~8.2.0 || ~8.3.0 || ~8.4.0",
"psr/log": "^2.0 || ^3.0",
"psr/http-client": "^1.0",
"php-http/discovery": "^1.0"
Expand Down
2 changes: 1 addition & 1 deletion src/lib/doctrine-dbal-bulk/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"upsert"
],
"require": {
"php": "~8.1.0 || ~8.2.0 || ~8.3.0",
"php": "~8.1.0 || ~8.2.0 || ~8.3.0 || ~8.4.0",
"doctrine/dbal": "^3.6 || ^4.0"
},
"autoload": {
Expand Down
2 changes: 1 addition & 1 deletion src/lib/dremel/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"algorithm"
],
"require": {
"php": "~8.1.0 || ~8.2.0 || ~8.3.0"
"php": "~8.1.0 || ~8.2.0 || ~8.3.0 || ~8.4.0"
},
"config": {
"optimize-autoloader": true,
Expand Down
2 changes: 1 addition & 1 deletion src/lib/filesystem/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"gcp"
],
"require": {
"php": "~8.1.0 || ~8.2.0 || ~8.3.0",
"php": "~8.1.0 || ~8.2.0 || ~8.3.0 || ~8.4.0",
"webmozart/glob": "^3.0 || ^4.0"
},
"config": {
Expand Down
2 changes: 1 addition & 1 deletion src/lib/parquet-viewer/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"parquet"
],
"require": {
"php": "~8.1.0 || ~8.2.0 || ~8.3.0",
"php": "~8.1.0 || ~8.2.0 || ~8.3.0 || ~8.4.0",
"coduo/php-humanizer": "^5.0",
"flow-php/etl": "^0.10.0 || 1.x-dev",
"flow-php/parquet": "^0.10.0 || 1.x-dev",
Expand Down
2 changes: 1 addition & 1 deletion src/lib/parquet/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"parquet"
],
"require": {
"php": "~8.1.0 || ~8.2.0 || ~8.3.0",
"php": "~8.1.0 || ~8.2.0 || ~8.3.0 || ~8.4.0",
"ext-bcmath": "*",
"ext-zlib": "*",
"composer-runtime-api": "^2.1",
Expand Down
2 changes: 1 addition & 1 deletion src/lib/parquet/tests/Flow/Parquet/Tests/Integration/Binary/BinaryReaderWriterTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ public static function decimalProvider() : array
['decimals' => [12345.67890, 98765.43210], 'precision' => 12, 'scale' => 5],
['decimals' => [0.0000000123456, 0.0000000987654], 'precision' => 16, 'scale' => 16],
['decimals' => [1234567890.12, 9876543210.98], 'precision' => 12, 'scale' => 2],
['decimals' => [1.234567890123456, 9.876543210987654], 'precision' => 17, 'scale' => 15],
['decimals' => [1.234567890123456, 9.876543210987654], 'precision' => 17, 'scale' => 16],
['decimals' => [123456789012.345, 987654321098.765], 'precision' => 15, 'scale' => 3],
];
}
Expand Down
2 changes: 1 addition & 1 deletion src/lib/rdsl/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"compression"
],
"require": {
"php": "~8.1.0 || ~8.2.0 || ~8.3.0"
"php": "~8.1.0 || ~8.2.0 || ~8.3.0 || ~8.4.0"
},
"config": {
"optimize-autoloader": true,
Expand Down
2 changes: 1 addition & 1 deletion src/lib/snappy/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"compression"
],
"require": {
"php": "~8.1.0 || ~8.2.0 || ~8.3.0"
"php": "~8.1.0 || ~8.2.0 || ~8.3.0 || ~8.4.0"
},
"config": {
"optimize-autoloader": true,
Expand Down
Loading