Skip to content

Conversation

@stloyd
Copy link
Member

@stloyd stloyd commented Dec 6, 2024

Change Log

Added

  • Run test suite on windows

Fixed

Changed

Removed

Deprecated

Security


Description

@stloyd stloyd force-pushed the feature/win-crap branch 3 times, most recently from 0a783a5 to 63f8747 Compare December 6, 2024 18:22
@github-actions github-actions bot added size: M and removed size: S labels Dec 6, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+------------------+------------------+----------------+
| benchmark             | subject           | revs | its | mem_peak         | mode             | rstdev         |
+-----------------------+-------------------+------+-----+------------------+------------------+----------------+
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.640mb +0.01%   | 516.947ms -1.02% | ±1.89% -33.70% |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 4.736mb +0.01%   | 1.102s +0.69%    | ±1.07% -24.86% |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 102.369mb +0.00% | 935.551ms -1.17% | ±0.18% -91.21% |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.368mb +0.01%   | 33.290ms -0.80%  | ±1.62% +50.93% |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.349mb +0.01%   | 655.078ms -0.30% | ±0.72% +45.95% |
+-----------------------+-------------------+------+-----+------------------+------------------+----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev         |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 116.643mb +0.00% | 59.845ms -1.19% | ±0.36% -84.60% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev         |
+--------------------+----------------+------+-----+------------------+------------------+----------------+
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 54.837mb +0.00%  | 139.558ms -1.47% | ±0.21% -72.25% |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 90.471mb +0.00%  | 119.089ms +1.61% | ±1.11% -7.90%  |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 255.240mb +0.00% | 21.415s -2.46%   | ±0.78% -55.16% |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.559mb +0.00%  | 44.484ms +0.73%  | ±0.52% -70.79% |
+--------------------+----------------+------+-----+------------------+------------------+----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode             | rstdev          |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 87.392mb +0.00%  | 3.393ms -7.55%   | ±2.61% +247.56% |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 102.995mb +0.00% | 187.734ms +0.63% | ±0.21% -56.02%  |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 85.715mb +0.00%  | 18.724ms -0.15%  | ±1.88% +336.00% |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 88.632mb +0.00%  | 1.955ms -4.49%   | ±3.04% +176.77% |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 88.632mb +0.00%  | 1.859ms -14.87%  | ±2.14% -40.98%  |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 85.744mb +0.00%  | 2.949ms -9.47%   | ±0.44% -88.24%  |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 86.273mb +0.00%  | 17.622ms -8.79%  | ±0.80% -57.66%  |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 86.273mb +0.00%  | 18.077ms -8.14%  | ±1.00% -2.04%   |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 84.176mb +0.00%  | 1.706μs -9.92%   | ±2.72% +7.69%   |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 84.176mb +0.00%  | 0.300μs -25.00%  | ±0.00% -100.00% |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 93.527mb +0.00%  | 12.554ms -6.82%  | ±2.73% +44.96%  |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 122.897mb +0.00% | 62.638ms -1.94%  | ±1.29% +74.13%  |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 86.792mb +0.00%  | 1.554ms -6.12%   | ±2.78% +18.53%  |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 90.144mb +0.00%  | 65.825ms +2.04%  | ±0.75% +57.45%  |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 88.894mb +0.00%  | 4.476ms +2.51%   | ±2.38% +66.99%  |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 84.326mb +0.00%  | 40.687ms +1.43%  | ±2.26% +104.19% |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 84.326mb +0.00%  | 40.173ms +0.64%  | ±0.31% -87.34%  |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 84.326mb +0.00%  | 40.159ms -5.05%  | ±1.64% -28.72%  |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 86.618mb +0.00%  | 7.317ms -2.89%   | ±0.89% -51.35%  |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 84.176mb +0.00%  | 28.760ms -3.51%  | ±1.53% -22.84%  |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 84.176mb +0.00%  | 13.330μs -7.08%  | ±1.75% -41.83%  |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 84.176mb +0.00%  | 16.601μs +3.48%  | ±1.97% -3.21%   |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 102.996mb +0.00% | 190.696ms -0.19% | ±0.66% -20.17%  |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 53.218mb +0.00%  | 390.550ms -0.80% | ±0.63% +28.23%  |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 13.484mb +0.00%  | 79.514ms -1.26%  | ±0.45% -65.15%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 107.480mb +0.00% | 492.193ms +1.19% | ±0.47% -68.04%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 55.838mb +0.00%  | 239.529ms +1.60% | ±1.43% +587.76% |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.676mb +0.00%  | 51.850ms -0.97%  | ±0.78% -60.28%  |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+

@stloyd
Copy link
Member Author

stloyd commented Dec 6, 2024

Closing as I don't have Windows locally and fixing quirks for the system is no fun for me.

@stloyd stloyd closed this Dec 6, 2024
@norberttech norberttech mentioned this pull request Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant