Skip to content

Conversation

@norberttech
Copy link
Member

@norberttech norberttech commented Dec 25, 2024

Change Log

Added

  • S3 Filesystem based on Async AWS library
  • Timeout to testsuite job at github actios

Fixed

  • Meilisearch pagination

Changed

Removed

Deprecated

Security


Description

@github-actions
Copy link
Contributor

github-actions bot commented Dec 25, 2024

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak        | mode             | rstdev          |
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.633mb +1.76%  | 519.635ms -0.00% | ±0.58% +98.29%  |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 4.737mb +1.72%  | 1.112s -1.12%    | ±0.42% -70.31%  |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 86.383mb +0.09% | 896.730ms -1.23% | ±0.67% -29.61%  |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.366mb +1.87%  | 34.030ms +0.73%  | ±1.53% +243.54% |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.342mb +1.88%  | 663.496ms +0.54% | ±0.12% -80.38%  |
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev         |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 114.363mb +0.07% | 61.210ms -0.17% | ±0.45% -61.16% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev         |
+--------------------+----------------+------+-----+------------------+------------------+----------------+
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 55.106mb +0.15%  | 112.272ms -0.49% | ±1.17% +26.52% |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 85.508mb +0.17%  | 103.594ms -0.32% | ±1.09% +73.22% |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 167.354mb +0.05% | 19.215s -0.76%   | ±0.36% +73.44% |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.191mb +0.47%  | 43.267ms -3.73%  | ±0.58% +11.88% |
+--------------------+----------------+------+-----+------------------+------------------+----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+------------------+-------------------------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode             | rstdev                        |
+-------------------------+----------------------------+------+-----+------------------+------------------+-------------------------------+
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 85.425mb +0.09%  | 3.083ms -4.37%   | ±0.86% +44.57%                |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 102.694mb +0.07% | 200.700ms +6.85% | ±0.19% -66.49%                |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 85.414mb +0.09%  | 19.832ms +7.30%  | ±0.17% -34.46%                |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 86.300mb +0.09%  | 1.391ms -9.29%   | ±0.37% -79.58%                |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 86.300mb +0.09%  | 1.412ms -3.66%   | ±0.69% -43.49%                |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 84.460mb +0.09%  | 2.177ms -4.74%   | ±0.69% -70.06%                |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 84.989mb +0.09%  | 16.920ms +14.78% | ±0.53% -57.10%                |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 84.989mb +0.09%  | 17.082ms +16.25% | ±0.93% -0.52%                 |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 83.680mb +0.09%  | 1.794μs -5.58%   | ±2.67% +22832449392073000.00% |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 83.680mb +0.09%  | 0.300μs -25.00%  | ±0.00% -100.00%               |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 92.258mb +0.08%  | 12.737ms -2.40%  | ±0.56% -69.47%                |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 120.566mb +0.06% | 59.397ms -4.08%  | ±0.46% -86.18%                |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 85.509mb +0.09%  | 1.183ms -8.19%   | ±1.60% -11.26%                |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 88.798mb +0.09%  | 58.932ms -1.60%  | ±2.59% +48.95%                |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 86.562mb +0.09%  | 3.481ms -3.06%   | ±0.29% +1155.43%              |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 83.956mb +0.09%  | 41.130ms -0.39%  | ±0.99% -3.52%                 |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 83.956mb +0.09%  | 40.552ms -3.31%  | ±0.93% +70.83%                |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 83.956mb +0.09%  | 40.620ms -0.58%  | ±1.59% +95.32%                |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 86.121mb +0.09%  | 7.640ms -0.44%   | ±1.72% +74.66%                |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 83.871mb +0.09%  | 29.076ms -1.57%  | ±1.01% +5.70%                 |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 83.680mb +0.09%  | 12.794μs -3.94%  | ±0.37% -65.01%                |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 83.680mb +0.09%  | 15.188μs -2.02%  | ±0.62% -40.87%                |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 102.695mb +0.08% | 201.852ms +6.14% | ±0.79% +45.56%                |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 50.579mb +0.15%  | 399.721ms -0.18% | ±1.20% +3.65%                 |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 12.994mb +0.58%  | 80.617ms -0.46%  | ±0.49% -54.89%                |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 105.837mb +0.07% | 480.691ms -0.57% | ±0.80% +93.39%                |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 55.027mb +0.14%  | 244.422ms -0.03% | ±0.77% +49.15%                |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.549mb +0.52%  | 52.454ms -2.32%  | ±0.60% -35.20%                |
+-------------------------+----------------------------+------+-----+------------------+------------------+-------------------------------+

@norberttech norberttech force-pushed the feature/aws-filesystem branch from 8049358 to 5bd53b2 Compare December 27, 2024 17:52
@norberttech norberttech force-pushed the feature/aws-filesystem branch from c9c206a to 39c62d2 Compare December 28, 2024 03:43
@norberttech norberttech merged commit 4107013 into flow-php:1.x Dec 28, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant