Skip to content

Conversation

@norberttech
Copy link
Member

@norberttech norberttech commented Oct 12, 2025

Resolves: #1892

Change Log


Added

  • Mago code formatter to static analysis tasks
  • Mago linter to static analysis tasks

Fixed

Changed

Removed

  • PHP CS Fixer

Deprecated

Security

The only reason why we can't really yet drop rector is: carthage-software/mago#555

@codecov
Copy link

codecov bot commented Oct 12, 2025

Codecov Report

❌ Patch coverage is 83.46774% with 82 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.37%. Comparing base (1d4c142) to head (089ca90).
⚠️ Report is 68 commits behind head on 1.x.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##              1.x    #1894   +/-   ##
=======================================
  Coverage   83.37%   83.37%           
=======================================
  Files        1017     1017           
  Lines       37268    37297   +29     
=======================================
+ Hits        31071    31098   +27     
- Misses       6197     6199    +2     
Components Coverage Δ
etl 87.41% <82.70%> (ø)
cli 85.76% <96.42%> (ø)
lib-array-dot 95.00% <ø> (ø)
lib-azure-sdk 60.01% <ø> (ø)
lib-doctrine-dbal-bulk 95.14% <ø> (ø)
lib-filesystem 80.44% <ø> (ø)
lib-types 87.40% <ø> (+0.04%) ⬆️
lib-parquet 68.25% <ø> (ø)
lib-parquet-viewer 83.04% <ø> (ø)
lib-snappy 90.18% <ø> (+0.46%) ⬆️
bridge-filesystem-async-aws 90.95% <91.30%> (ø)
bridge-filesystem-azure 89.38% <86.95%> (ø)
bridge-monolog-http 96.89% <100.00%> (ø)
bridge-openapi-specification 94.50% <ø> (ø)
symfony-http-foundation 72.32% <71.42%> (ø)
adapter-chartjs 86.33% <71.42%> (ø)
adapter-csv 89.30% <80.00%> (ø)
adapter-doctrine 91.50% <100.00%> (ø)
adapter-elasticsearch 97.02% <100.00%> (ø)
adapter-google-sheet 97.05% <100.00%> (ø)
adapter-http 65.94% <100.00%> (ø)
adapter-json 89.69% <80.00%> (ø)
adapter-logger 83.33% <100.00%> (ø)
adapter-meilisearch 97.77% <100.00%> (ø)
adapter-parquet 79.63% <80.00%> (ø)
adapter-text 86.84% <80.00%> (ø)
adapter-xml 82.66% <77.77%> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@norberttech norberttech force-pushed the 1892-replace-php-cs-fixer-and-rector-with-mago-linter-formatter branch from 937c910 to 0aa1a86 Compare November 9, 2025 11:27
@norberttech norberttech marked this pull request as draft November 9, 2025 11:27
@norberttech norberttech force-pushed the 1892-replace-php-cs-fixer-and-rector-with-mago-linter-formatter branch from 0aa1a86 to 345c4eb Compare November 10, 2025 11:51
@norberttech norberttech force-pushed the 1892-replace-php-cs-fixer-and-rector-with-mago-linter-formatter branch from 345c4eb to f753dd7 Compare December 4, 2025 16:46
@norberttech norberttech force-pushed the 1892-replace-php-cs-fixer-and-rector-with-mago-linter-formatter branch from f753dd7 to c454827 Compare December 12, 2025 11:12
@norberttech
Copy link
Member Author

Closing it for now due to more urgent issues/features waiting in the roadmap. Mago is geat, I want to migrate into it, but it already consumed waaaaaaaay to much of my time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace PHP-CS-Fixer and Rector with Mago Linter & Formatter

2 participants