Move JSON & Uuid validation out of StringTypeNarrower#1958
Merged
norberttech merged 1 commit intoflow-php:1.xfrom Nov 5, 2025
Merged
Move JSON & Uuid validation out of StringTypeNarrower#1958norberttech merged 1 commit intoflow-php:1.xfrom
StringTypeNarrower#1958norberttech merged 1 commit intoflow-php:1.xfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 1.x #1958 +/- ##
==========================================
- Coverage 79.78% 79.78% -0.01%
==========================================
Files 834 834
Lines 24779 24774 -5
==========================================
- Hits 19771 19767 -4
+ Misses 5008 5007 -1
🚀 New features to boost your workflow:
|
norberttech
requested changes
Nov 5, 2025
Member
norberttech
left a comment
There was a problem hiding this comment.
Not whole json validation is covered with unit tests (that's why CI/CD complains)
Also please look at who is assigned to a task/issue 😅 this one was actually assigned to @MrHDOLEK
stloyd
commented
Nov 5, 2025
stloyd
commented
Nov 5, 2025
Member
|
Sweet <3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #1952
Change Log
Added
Fixed
Changed
Removed
Deprecated
Security