fix: text formatting of nameless exec and linting

Author: jahvon

.github/workflows/analyze.yaml

@@ -54,7 +54,7 @@ jobs:
       - name: golangci-lint
         uses: golangci/golangci-lint-action@v6
         with:
-          version: v1.60.3
+          version: v1.64.5
           args: --out-format=sarif:results.sarif,colored-line-number,github-actions
       - name: Upload SARIF file
         uses: github/codeql-action/upload-sarif@v3

.golangci.yaml

@@ -92,6 +92,8 @@ issues:
         - gosec
         - noctx
         - wrapcheck
+    - linters: [gosec]
+      text: "G115"
     - linters:
         - staticcheck
       text: "SA5011" # SA5011: Should not use unsafe.Pointer - this throws false positives when a nil check does not result in a return

cmd/internal/flags/helpers.go

@@ -10,6 +10,7 @@ import (
 	"github.com/jahvon/flow/internal/context"
 )
 
+//nolint:errcheck
 func ToPflag(cmd *cobra.Command, metadata Metadata, persistent bool) (*pflag.FlagSet, error) {
 	flagSet := cmd.Flags()
 	if persistent {
@@ -66,6 +67,7 @@ func ToPflag(cmd *cobra.Command, metadata Metadata, persistent bool) (*pflag.Fla
 	return flagSet, nil
 }
 
+//nolint:errcheck
 func ValueFor[T any](ctx *context.Context, cmd *cobra.Command, metadata Metadata, persistent bool) T {
 	logger := ctx.Logger
 	flagName := metadata.Name

cmd/internal/flags/helpers_test.go

@@ -71,7 +71,7 @@ var _ = Describe("ValueFor", func() {
 			Expect(err).NotTo(HaveOccurred())
 			cmd.Flags().AddFlagSet(flagset)
 			if reflect.TypeOf(expectedValue).Kind() == reflect.Slice {
-				err = cmd.ParseFlags([]string{"--test", expectedValue.([]string)[0]})
+				err = cmd.ParseFlags([]string{"--test", expectedValue.([]string)[0]}) //nolint:errcheck
 			} else {
 				err = cmd.ParseFlags([]string{"--test=" + fmt.Sprintf("%v", expectedValue)})
 			}

internal/crypto/crypto.go

@@ -78,7 +78,7 @@ func EncryptValue(encryptionKey string, text string) (string, error) {
 		return "", fmt.Errorf("error reading random bytes: %w", err)
 	}
 
-	cfb := cipher.NewCFBEncrypter(block, iv)
+	cfb := cipher.NewCTR(block, iv)
 	cfb.XORKeyStream(ciphertext[aes.BlockSize:], plaintext)
 	return string(ciphertext), nil
 }
@@ -103,7 +103,7 @@ func DecryptValue(encryptionKey string, text string) (string, error) {
 	iv := ciphertext[:aes.BlockSize]
 	ciphertext = ciphertext[aes.BlockSize:]
 
-	cfb := cipher.NewCFBDecrypter(block, iv)
+	cfb := cipher.NewCTR(block, iv)
 	cfb.XORKeyStream(plainText, ciphertext)
 	return string(plainText), nil
 }

internal/crypto/crypto_test.go

@@ -3,9 +3,10 @@ package crypto_test
 import (
 	"testing"
 
-	"github.com/jahvon/flow/internal/crypto"
 	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
+
+	"github.com/jahvon/flow/internal/crypto"
 )
 
 func TestCrypto(t *testing.T) {

internal/io/library/view.go

@@ -41,7 +41,7 @@ var (
 func (l *Library) View() string {
 	l.paneZeroViewport.Style = paneStyle(0, l.theme, l.splitView)
 	l.paneZeroViewport.SetContent(l.paneZeroContent())
-	l.paneZeroViewport.SetYOffset(int(l.currentWorkspace + l.currentNamespace)) //nolint:gosec
+	l.paneZeroViewport.SetYOffset(int(l.currentWorkspace + l.currentNamespace))
 
 	l.paneOneViewport.Style = paneStyle(1, l.theme, l.splitView)
 	l.paneOneViewport.SetContent(l.paneOneContent())

types/executable/executable.go

@@ -504,11 +504,23 @@ func MustParseExecutableID(id string) (workspace, namespace, name string) {
 }
 
 func NewExecutableID(workspace, namespace, name string) string {
-	if namespace == "" || namespace == WildcardNamespace {
-		return fmt.Sprintf("%s/%s", workspace, name)
+	var ws, ns string
+	if namespace != "" && namespace != WildcardNamespace {
+		ns = namespace
 	}
-	if workspace == "" || workspace == WildcardWorkspace {
-		return fmt.Sprintf("%s:%s", namespace, name)
+	if workspace != "" && workspace != WildcardWorkspace {
+		ws = workspace
+	}
+
+	switch {
+	case ws == "", ns != "" && name == "":
+		return "" // TODO: return error or log warning
+	case ns != "":
+		return fmt.Sprintf("%s/%s:%s", ws, ns, name)
+	case name != "":
+		return fmt.Sprintf("%s/%s", ws, name)
+	default: // ws != "" && ns == "" && name == ""
+		// for now, exclude the workspace from the string (until we can indicate that it's root / not named in the tui)
+		return ""
 	}
-	return fmt.Sprintf("%s/%s:%s", workspace, namespace, name)
 }