Skip to content

feat!: use expr language for executable templates and request transformations#204

Merged
jahvon merged 6 commits intomainfrom
temp-to-expr
Feb 16, 2025
Merged

feat!: use expr language for executable templates and request transformations#204
jahvon merged 6 commits intomainfrom
temp-to-expr

Conversation

@jahvon
Copy link
Member

@jahvon jahvon commented Dec 27, 2024

Replaces Sprig, jq and standard Go templating funcs with Expr lang to align with usage in ref config conditionals. This update changes the templating language across Request exec transformations and all flowfile template fields. See updated docs for more info.

This is a breaking change! If these fields are set anywhere, they will need to be converted to the expr counterpart.

@codecov
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 82 lines in your changes missing coverage. Please review.

Project coverage is 22.65%. Comparing base (4606279) to head (165fa33).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/services/expr/template.go 79.25% 22 Missing and 6 partials ⚠️
internal/templates/templates.go 0.00% 24 Missing ⚠️
internal/templates/expression.go 0.00% 18 Missing ⚠️
internal/templates/artifacts.go 0.00% 6 Missing ⚠️
internal/services/expr/expr.go 50.00% 3 Missing ⚠️
internal/services/rest/rest.go 75.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #204      +/-   ##
==========================================
+ Coverage   21.39%   22.65%   +1.26%     
==========================================
  Files          77       79       +2     
  Lines        6604     6739     +135     
==========================================
+ Hits         1413     1527     +114     
- Misses       4923     4937      +14     
- Partials      268      275       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jahvon jahvon marked this pull request as ready for review February 16, 2025 03:19
@jahvon jahvon changed the title wip!: use expr language for executable templates feat!: use expr language for executable templates and request transformations Feb 16, 2025
@jahvon jahvon merged commit 926c2ad into main Feb 16, 2025
6 checks passed
@jahvon jahvon deleted the temp-to-expr branch February 16, 2025 03:31
@jahvon jahvon added this to the v1.0 milestone Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments