Skip to content

Comments

feat: add ability to set params via exec arg#248

Merged
jahvon merged 3 commits intomainfrom
override-param
Jun 27, 2025
Merged

feat: add ability to set params via exec arg#248
jahvon merged 3 commits intomainfrom
override-param

Conversation

@jahvon
Copy link
Member

@jahvon jahvon commented Jun 27, 2025

This pull request introduces enhancements to the exec command functionality. The most significant change includes adding support for the --param flag to override environment variables. This allows skipping of the prompt form whenever a value is overriden. Note: values set this way now take presence over anything defined in the config.

Note to self: this should help with testing and the desktop integration but I may need to think about how this relates to the args on an executable

@codecov
Copy link

codecov bot commented Jun 27, 2025

Codecov Report

Attention: Patch coverage is 12.90323% with 27 lines in your changes missing coverage. Please review.

Project coverage is 21.90%. Comparing base (4a8303c) to head (67cf0f3).

Files with missing lines Patch % Lines
cmd/internal/exec.go 0.00% 27 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #248      +/-   ##
==========================================
- Coverage   21.92%   21.90%   -0.03%     
==========================================
  Files          84       84              
  Lines        7046     7067      +21     
==========================================
+ Hits         1545     1548       +3     
- Misses       5221     5239      +18     
  Partials      280      280              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jahvon jahvon marked this pull request as ready for review June 27, 2025 19:01
@jahvon jahvon merged commit db23c3e into main Jun 27, 2025
6 of 8 checks passed
@jahvon jahvon deleted the override-param branch June 27, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant