Skip to content

Conversation

@jahvon
Copy link
Member

@jahvon jahvon commented Jul 6, 2025

See commit details

jahvon added 3 commits July 5, 2025 21:25
fixes a cache read deadlock when there is a serial or parallel exec
includes in another serial or parallel exec
when the same nameless exec is used across workspaces, it sometimes
may not be the exec returned. this fixes the issue by including the
ws in the returned id
@jahvon jahvon changed the title Misc fixes fix: misc execution related bugs and exec updates Jul 6, 2025
@codecov
Copy link

codecov bot commented Jul 6, 2025

Codecov Report

Attention: Patch coverage is 38.09524% with 13 lines in your changes missing coverage. Please review.

Project coverage is 42.35%. Comparing base (441c06b) to head (43569e9).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
internal/runner/parallel/parallel.go 33.33% 4 Missing and 2 partials ⚠️
internal/runner/serial/serial.go 33.33% 4 Missing and 2 partials ⚠️
types/executable/executable.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #256      +/-   ##
==========================================
- Coverage   42.37%   42.35%   -0.02%     
==========================================
  Files          91       91              
  Lines        8362     8365       +3     
==========================================
  Hits         3543     3543              
- Misses       4241     4244       +3     
  Partials      578      578              
Flag Coverage Δ
combined 42.35% <38.09%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jahvon jahvon marked this pull request as ready for review July 6, 2025 01:49
@jahvon jahvon merged commit 4ee75fd into main Jul 6, 2025
14 of 15 checks passed
@jahvon jahvon deleted the misc-fixes branch July 6, 2025 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants