Improve performance when moving groups of nodes#305
Open
ifitzpatrick wants to merge 1 commit intoflowhub:masterfrom
Open
Improve performance when moving groups of nodes#305ifitzpatrick wants to merge 1 commit intoflowhub:masterfrom
ifitzpatrick wants to merge 1 commit intoflowhub:masterfrom
Conversation
Collaborator
|
Smells like somewhere a refactor fluxy dataflow would help. |
Contributor
Author
|
Would we be able to avoid triggering a rerender of the whole graph view if we did that? |
Member
|
Waiting until |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The app is slowed down a lot when moving groups because each individual node in the group triggers an update cycle. By only calling markDirty once all of the noflo.Graph listeners have been called for each node, we can speed up this ui interaction quite a bit.