[Query] Does Call #2139
Merged
[Query] Does Call #2139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
There was a problem hiding this comment.
Pull request overview
This pull request introduces a new "Does Call" query feature that enables checking whether a function calls another function matching specified constraints. The PR includes:
- Implementation of the new
does-callquery with support for name-based and id-based constraints with logical operators (and, or) - Refactoring of call graph generation to improve accuracy of call relationships
- Comprehensive test coverage for the new query functionality
- Dependency updates including esbuild, release-it, and various development tools
- Auto-generated documentation updates reflecting timing changes
Reviewed changes
Copilot reviewed 29 out of 33 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/queries/catalog/does-call-query/does-call-query-format.ts |
New query format definition with constraint types and CLI parser |
src/queries/catalog/does-call-query/does-call-query-executor.ts |
Query executor implementing constraint matching and call graph traversal |
test/functionality/dataflow/query/does-call-query.test.ts |
Comprehensive tests for the new query including recursion, aliasing, and logical operators |
src/dataflow/graph/call-graph.ts |
Significant refactoring to improve call graph accuracy with better handling of untargeted calls and aliases |
src/dataflow/internal/process/functions/call/unnamed-call-handling.ts |
Changed edge type from Calls to Reads for unnamed function calls |
src/dataflow/internal/linker.ts |
Added DefinedByOnCall to link read bits |
package.json |
Updated dependencies including esbuild, license-checker, and release-it |
| Multiple test files | Adjusted expectations for call graph edges based on refactored logic |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
This pull request is included in v2.8.0 (see Release v2.8.0 (Call-Graphs, Roxygen 2 Support, Many Plugins, Registrations, Exceptions and Hooks)). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.