Skip to content

Conversation

@EagleoutIce
Copy link
Member

No description provided.

@EagleoutIce EagleoutIce linked an issue Jan 5, 2026 that may be closed by this pull request
@EagleoutIce EagleoutIce requested a review from Copilot January 5, 2026 12:11
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors array operations to reduce stack/memory burden by replacing spread operators and array concatenations with explicit loops. The main goal is to avoid creating intermediate arrays during iteration and copying operations.

Key changes:

  • Replaced spread operator patterns with nested loops to avoid intermediate array allocations
  • Substituted spread syntax copying ([...array]) with Array.from() for explicit array copying
  • Converted concat() operations with explicit loops where appropriate

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/dataflow/internal/process/functions/call/built-in/built-in-expression-list.ts Replaced concat() in for-loop with nested loops to iterate over both processed.in and processed.unknownReferences
src/dataflow/internal/process/functions/call/built-in/built-in-assignment.ts Refactored produceWrittenNodes to use explicit loops and manual object construction instead of spread operators and map
src/control-flow/extract-cfg.ts Multiple refactorings replacing spread operators with nested loops, Array.from(), and .concat() calls; removed blank lines

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@EagleoutIce EagleoutIce merged commit 6dfc15e into main Jan 5, 2026
25 checks passed
@EagleoutIce EagleoutIce deleted the 2197-cfg-max-call-stack-size-exceeded branch January 5, 2026 12:19
@EagleoutIce
Copy link
Member Author

This pull request is included in v2.8.4 (see Release v2.8.4 (Extractor Instrumentation, Bugfixes, and Support for more Versions)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CFG] Max Call-stack Size Exceeded

2 participants