Skip to content

Conversation

@EagleoutIce
Copy link
Member

No description provided.

@EagleoutIce EagleoutIce linked an issue Jan 5, 2026 that may be closed by this pull request
@EagleoutIce EagleoutIce requested a review from Copilot January 5, 2026 17:07
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds an involvedId field to linting results to track which AST node is associated with each linting issue, enabling better traceability and tooling support.

  • Adds involvedId: NodeId | undefined field to the LintingResult interface
  • Updates 8 linter rules to populate the involvedId field from the relevant AST nodes
  • Modifies test infrastructure to exclude involvedId from test assertions for easier test maintenance
  • Implements flattenInvolvedNodes in the linter query to extract involved node IDs

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/linter/linter-format.ts Adds the involvedId field to the LintingResult interface with documentation
test/functionality/_helper/linter.ts Introduces cleanUpLintingResult helper to strip involvedId from test comparisons
test/functionality/linter/lint-dataframe-access-validation.test.ts Updates test type to exclude involvedId from expected results
src/queries/catalog/linter-query/linter-query-format.ts Implements flattenInvolvedNodes to collect node IDs from linting results
src/linter/rules/useless-loop.ts Populates involvedId from loop node
src/linter/rules/unused-definition.ts Populates involvedId from definition node
src/linter/rules/seeded-randomness.ts Populates involvedId from consumer call node
src/linter/rules/naming-convention.ts Populates involvedId from identifier node
src/linter/rules/function-finder-util.ts Populates involvedId from function call node
src/linter/rules/file-path-validity.ts Populates involvedId from file read node
src/linter/rules/dead-code.ts Sets involvedId to undefined for combined dead code ranges
src/linter/rules/dataframe-access-validation.ts Populates involvedId from data frame access node

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@EagleoutIce EagleoutIce merged commit e308d9a into main Jan 5, 2026
19 checks passed
@EagleoutIce EagleoutIce deleted the 2205-linter-needs-to-give-involved-node-id branch January 5, 2026 17:12
@EagleoutIce
Copy link
Member Author

This pull request is included in v2.8.5 (see Release v2.8.5 (Provide IDs in linting rules)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Linter] Needs to give involved node id!

2 participants