feat: Http Api lambda handler

[floydspace]

issue #83

[changeset-bot]

🦋 Changeset detected

Latest commit: 845ac99

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@effect-aws/lambda	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[arjunyel]

Thank you for the excellent work! Is this blocked on anything?

Looking through the code, one thing that might be missing are Lambda Function URL events

import type { LambdaFunctionURLEvent } from "aws-lambda";

https://docs.aws.amazon.com/lambda/latest/dg/urls-configuration.html

[floydspace]

it is a bit blocking to make a decision if we need to handle all the events (I feel like supporting events like sns/sqs and etc. are not really usefull)

• lack of proper testing.

I will do my best to prioritoze it.
And thanks for your interest, it's good to see it is awaited

[arjunyel]

it is a bit blocking to make a decision if we need to handle all the events (I feel like supporting events like sns/sqs and etc. are not really usefull)

• lack of proper testing.

I will do my best to prioritoze it. And thanks for your interest, it's good to see it is awaited

Thank you so much friend! I can't speak for others but for my HttpApis I have been using Lamda function URLs. I don't think people would use an http API with a sns and sqs events. I think if you support function URLs and API gateway that would cover most use cases.

One thing that may make things more complicated is supporting Lambda streaming. Here is how Hono handles it: https://github.com/honojs/hono/blob/15a83b125cae5a772f265ce448974c03efa5e3bc/src/adapter/aws-lambda/handler.ts#L108

[floydspace]

Here is how Hono handles it

I just checked the Hono implementation, it looks good, I might take inspiration from it, the implementation in this PR is based on serverless-express, and it supports more events than hono, but I don't think all the events are usefull..
thanks for the reference

[floydspace]

Looking through the code, one thing that might be missing are Lambda Function URL events

import type { LambdaFunctionURLEvent } from "aws-lambda";

it is defined as type LambdaFunctionURLEvent = APIGatewayProxyEventV2 in @types/aws-lambda so it is actually covered