Skip to content

Use :cmd backend for Windows platform #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 18, 2025
Merged

Use :cmd backend for Windows platform #4

merged 1 commit into from
Aug 18, 2025

Conversation

@Watson1978
Copy link
Contributor

@Watson1978 Watson1978 commented Aug 18, 2025 •
edited
Loading

Seems :exec assumes Linux environment.

So, this patch uses :cmd as backend on Windows.

@Watson1978 Watson1978 requested a review from kenhys August 18, 2025 06:39
@Watson1978 Watson1978 marked this pull request as ready for review August 18, 2025 06:39
kenhys
kenhys approved these changes Aug 18, 2025
View reviewed changes
Copy link
Contributor

@kenhys kenhys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@kenhys kenhys merged commit 24156be into fluent-plugins-nursery:main Aug 18, 2025
6 checks passed
@Watson1978 Watson1978 deleted the windows branch August 18, 2025 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kenhys kenhys kenhys approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Watson1978 @kenhys