Skip to content

Conversation

@Watson1978
Copy link
Contributor

This patch will fix following Rubocop's suggestions:

$ bundle exec rubocop
Inspecting 5 files
C...C

Offenses:

Gemfile:8:1: C: [Correctable] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem rubocop-fluentd should appear before test-unit.
gem "test-unit-rr", "~> 1.0.5" ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Gemfile:9:1: C: [Correctable] Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem rubocop-fluentd should appear before test-unit-rr.
gem "rubocop-fluentd", "~> 0.2.0"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/fluent/plugin/in_fluent_package_update_notifier.rb:75:11: C: Performance/FluentdPluginLogStringInterpolation: Use log.error { "..." } instead of log.error("...")
          log.error "Failed to check updates: #{e.message}"
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

5 files inspected, 3 offenses detected, 2 offenses autocorrectable

@Watson1978 Watson1978 marked this pull request as ready for review August 18, 2025 06:59
@Watson1978 Watson1978 requested a review from kenhys August 18, 2025 06:59
@Watson1978 Watson1978 merged commit b69cea5 into fluent-plugins-nursery:main Aug 18, 2025
6 checks passed
@Watson1978 Watson1978 deleted the rubocop branch August 18, 2025 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant