Skip to content

Improve implementation#400

Merged
jcantrill merged 10 commits intofluent-plugins-nursery:masterfrom
w-masahiro-ct:improve-implementation
Jan 24, 2025
Merged

Improve implementation#400
jcantrill merged 10 commits intofluent-plugins-nursery:masterfrom
w-masahiro-ct:improve-implementation

Conversation

@w-masahiro-ct
Copy link
Contributor

What's changed

  • Update .gitignore
  • Bundle update
  • Improve gemspec (for spec.files)
  • Update ruby version to 2.7 in .rubocop.yml to keep in sync with .circleci/config.yml and gemspec
  • Install "rubocop-minitest", "rubocop-performance", "rubocop-rake"
  • Update .rubocop.yml
  • Refactor for rubocop
  • Fix bad practice that overrides String class
  • Update test gems and tests
  • Replace from CircleCI to GitHubActions

@w-masahiro-ct w-masahiro-ct force-pushed the improve-implementation branch from 71a4b0a to 03b6fb3 Compare January 23, 2025 15:38
@w-masahiro-ct w-masahiro-ct force-pushed the improve-implementation branch from 03b6fb3 to 163c28f Compare January 23, 2025 15:40
@jcantrill
Copy link
Contributor

Replace from CircleCI to GitHubActions

Thank you for you contributions, especially this one. I was unaware this org had Github actions available to it but have disired to replace CircleCI for sometime.

@jcantrill jcantrill merged commit 5b4dc5e into fluent-plugins-nursery:master Jan 24, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants