Add small sleep to retryment for GoneError#409
Open
daipom wants to merge 1 commit intofluent-plugins-nursery:masterfrom
Open
Add small sleep to retryment for GoneError#409daipom wants to merge 1 commit intofluent-plugins-nursery:masterfrom
daipom wants to merge 1 commit intofluent-plugins-nursery:masterfrom
Conversation
To fix unstable tests:
TestWatchNamespaces#test_0012_namespace watch retries when 410 Gone errors are encountered:
NoMethodError: undefined method `>=' for nil:NilClass
test/plugin/test_watch_namespaces.rb:250:in `block (3 levels) in <class:TestWatchNamespaces>'
test/plugin/test_watch_namespaces.rb:241:in `block (2 levels) in <class:TestWatchNamespaces>'
test/plugin/test_watch_namespaces.rb:240:in `block in <class:TestWatchNamespaces>'
TestWatchPods#test_0013_pod watch retries when 410 Gone errors are encountered:
NoMethodError: undefined method '>=' for nil
test/plugin/test_watch_pods.rb:360:in 'block (3 levels) in <class:TestWatchPods>'
test/plugin/test_watch_pods.rb:351:in 'block (2 levels) in <class:TestWatchPods>'
test/plugin/test_watch_pods.rb:350:in 'block in <class:TestWatchPods>'
It appears that the cause could be the infinite loop without
any sleep when GoneError occurs.
Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix unstable tests:
It appears that the cause could be the infinite loop without any sleep when GoneError occurs.