Skip to content

Conversation

@Watson1978
Copy link
Contributor

We can specify any tag for the filter because filter plugin does nothing.
However it would cause unnecessary method calls for filter.

It is preferable to run as an input plugin for simpler.

@Watson1978 Watson1978 requested a review from daipom August 6, 2025 03:23
Copy link

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

Copy link
Contributor

@kenhys kenhys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kenhys kenhys merged commit ab44003 into fluent-plugins-nursery:master Aug 6, 2025
3 checks passed
@Watson1978 Watson1978 deleted the add-input-plugin branch August 6, 2025 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants