Skip to content

Conversation

@TomlinfreeGit
Copy link

update out_pgsql plugin: add a configurable parameter to support run this plugin in a daemon mode.
if in daemon mode, configuration error of out_pgsql will not cause fluentbit crash or exit.

code Merge Request link as follows:
fluent/fluent-bit#7215

@github-actions
Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Jul 18, 2023
@lecaros lecaros requested review from a team as code owners March 25, 2025 14:34
@eschabell eschabell self-assigned this Oct 21, 2025
@eschabell eschabell removed the Stale label Oct 21, 2025
@eschabell
Copy link
Collaborator

@TomlinfreeGit can you resolve the conflicts here please? I've pushed on the review for the code PR fluent/fluent-bit#7215.

@eschabell eschabell self-requested a review October 21, 2025 13:08
@eschabell eschabell added waiting-for-user Waiting for user/contributors feedback or requested changes conflict Waiting on conflict to be resolved by contributor labels Oct 21, 2025
@patrick-stephens
Copy link
Contributor

I think something is going wrong, last few PRs show no changes to commit

@eschabell eschabell added the dco DCO failing label Oct 22, 2025
@eschabell eschabell requested review from esmerel and removed request for eschabell October 22, 2025 19:26
@eschabell
Copy link
Collaborator

@TomlinfreeGit looks like an unsigned commit was pushed here, that's causing the DCO failures, can you fix your commit?

@esmerel esmerel removed the conflict Waiting on conflict to be resolved by contributor label Oct 23, 2025
@esmerel
Copy link
Contributor

esmerel commented Oct 23, 2025

Fixed the overwritten line.

@TomlinfreeGit
Copy link
Author

Thanks for re-considering the proposal and help fix the comments!

@patrick-stephens
Copy link
Contributor

@TomlinfreeGit the DCO check is a hard requirement to merge so if you can sort that?

@TomlinfreeGit TomlinfreeGit changed the title update out_pgsql document update out_pgsql document Tom <[email protected]> Oct 28, 2025
@TomlinfreeGit TomlinfreeGit force-pushed the feature/daemon-out-pgsql branch from 1be6bcb to eacf596 Compare October 28, 2025 08:30
@TomlinfreeGit TomlinfreeGit force-pushed the feature/daemon-out-pgsql branch from eacf596 to 54ffe9f Compare October 28, 2025 08:40
@eschabell
Copy link
Collaborator

@TomlinfreeGit did you intend to close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco DCO failing waiting-for-user Waiting for user/contributors feedback or requested changes waiting-on-code-merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants